Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix vdso_get_symbols_info() assertion for ARM64 #24

Closed
wants to merge 1 commit into from
Closed

Fix vdso_get_symbols_info() assertion for ARM64 #24

wants to merge 1 commit into from

Commits on Sep 14, 2023

  1. Fix vdso_get_symbols_info() assertion for ARM64 

    On ARM64 I have been seeing test failures:

```
test vdso::tests::vdso_can_find_symbols_info ... FAILED
test vdso::tests::vdso_patch_info_is_valid ... FAILED
```

Looking closer, this was caused by the debug assertion in
vdso_get_symbols_info() which asserts that all symbols found in the VDSO
are ELF STT_FUNC symbols. Unfortunately, this is not the case on ARM64,
because the VDSO's `__kernel_rt_sigreturn` is special and does appear
as STT_NONE symbol.

Fixup the debug assertion by special-casing for this special function.

Signed-off-by: Bjoern Doebel <[email protected]>
    @bjoernd
    bjoernd committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    d467ec2 View commit details
    Browse the repository at this point in the history