Fix Abseil CMake package name #152
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
kou
force-pushed
the
abseil-cmake-package-name
branch
from
ffff7ab to
fc4ea02
Compare
It's "absl" not "abseil". If we use "abseil", -Dabseil_SOURCE=SYSTEM is never succeeded because abseilConfig.cmake doesn't exist. This also sets some ABSL_* variables like Velox does in https://github.com/facebookincubator/velox/blob/main/CMake/resolve_dependency_modules/absl.cmake .
kou
force-pushed
the
abseil-cmake-package-name
branch
from
fc4ea02 to
9ac24e0
Compare
Closed
Contributor
|
@kevinwilfong has imported this pull request. If you are a Meta employee, you can view this in D77894756. |
Contributor
|
@kevinwilfong merged this pull request in 0c0e130. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's "absl" not "abseil".
If we use "abseil", -Dabseil_SOURCE=SYSTEM is never succeeded because
abseilConfig.cmake doesn't exist.
This also sets some ABSL_* variables like Velox does in
https://github.com/facebookincubator/velox/blob/main/CMake/resolve_dependency_modules/absl.cmake
.