Add addition attributes in RunSpec #217
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Wu <[email protected]>
Signed-off-by: Alex Wu <[email protected]>
Signed-off-by: Alex Wu <[email protected]>
Signed-off-by: Alex Wu <[email protected]>
Signed-off-by: Alex Wu <[email protected]>
Signed-off-by: Alex Wu <[email protected]>
Signed-off-by: Alex Wu <[email protected]>
popojk
changed the title
|
@wild-endeavor @pvditt @squiishyy This is a PR to add addition attributes in RunSpec in SDK. Please review, thanks! |
popojk
changed the title
Signed-off-by: Alex Wu <[email protected]>
Signed-off-by: Alex Wu <[email protected]>
Signed-off-by: Alex Wu <[email protected]>
Signed-off-by: Alex Wu <[email protected]>
Signed-off-by: Alex Wu <[email protected]>
machichima
reviewed
Sep 27, 2025
src/flyte/_run.py
Outdated
| raw_data_storage = run_definition_pb2.RawDataStorage(raw_data_prefix=self._raw_data_path) | ||
| security_context = security_pb2.SecurityContext( | ||
| run_as=security_pb2.Identity( | ||
| k8s_service_account=self._service_account |
There was a problem hiding this comment.
Curious, do we also want to set other things in the SecurityContext in SDK?
Signed-off-by: Alex Wu <[email protected]>
Signed-off-by: Alex Wu <[email protected]>
Signed-off-by: Alex Wu <[email protected]>
src/flyte/cli/_run.py
Outdated
| "click.option": click.Option( | ||
| ["--service-account"], | ||
| type=str, | ||
| help="Kubernetes service account. If not provided, default will be used", |
There was a problem hiding this comment.
Suggested change
| help="Kubernetes service account. If not provided, default will be used", | |
| help="Kubernetes service account. If not provided, the configured default will be used", |
src/flyte/cli/_run.py
Outdated
| "click.option": click.Option( | ||
| ["--raw-data-path"], | ||
| type=str, | ||
| help="Override the output path to store the raw data. Example: s3://bucket/", |
There was a problem hiding this comment.
Suggested change
| help="Override the output path to store the raw data. Example: s3://bucket/", | |
| help="Override the output prefix used to store offloaded data types. e.g. s3://bucket/", |
src/flyte/_run.py
Outdated
| env_kv = run_pb2.Envs(values=kv_pairs) | ||
| annotations = run_pb2.Annotations(values=self._annotations) | ||
| labels = run_pb2.Labels(values=self._labels) | ||
| raw_data_storage = run_pb2.RawDataStorage(raw_data_prefix=self._raw_data_path) |
There was a problem hiding this comment.
i think we shouldn't send these at all if the values aren't defined. there's no point sending an empty object.
Signed-off-by: Alex Wu <[email protected]>
wild-endeavor
approved these changes
Oct 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
src/flyte/_run.pyto passservice_accountandraw_output_prefixinto RunSpec while creating a new run