-
Notifications
You must be signed in to change notification settings - Fork 18
Add addition attributes in RunSpec #217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from 15 commits
5e3d5c7
620949c
3346411
ef737f2
40a1fd0
58c1eef
afc2b08
c64781a
cc41cf7
fb4ee09
3360250
19a95d5
68b2ea8
f0833b5
34ceb29
2ecfcad
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -86,6 +86,26 @@ class RunArguments: | |||||
) | ||||||
}, | ||||||
) | ||||||
raw_data_path: str | None = field( | ||||||
default=None, | ||||||
metadata={ | ||||||
"click.option": click.Option( | ||||||
["--raw-data-path"], | ||||||
type=str, | ||||||
help="Override the output path to store the raw data. Example: s3://bucket/", | ||||||
|
help="Override the output path to store the raw data. Example: s3://bucket/", | |
help="Override the output prefix used to store offloaded data types. e.g. s3://bucket/", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed!
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
help="Kubernetes service account. If not provided, default will be used", | |
help="Kubernetes service account. If not provided, the configured default will be used", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think we shouldn't send these at all if the values aren't defined. there's no point sending an empty object.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed! Thank you