Skip to content

fix proto #6685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: v2
Choose a base branch
from
Open

fix proto #6685

wants to merge 2 commits into from

Conversation

@popojk
Copy link
Contributor

@popojk popojk commented Oct 20, 2025

Tracking issue

n/a

Why are the changes needed?

We need to update proto for ListRuns api scope by task identifier

What changes were proposed in this pull request?

Update run_service.proto and regenerate

How was this patch tested?

Test in parent PR

Check all the applicable boxes

  • All new and existing tests passed.
  • All commits are signed-off.

@popojk
fix proto
7a184a5 
Signed-off-by: Alex Wu <[email protected]>
@flyte-bot
Copy link
Collaborator

flyte-bot commented Oct 20, 2025

Bito Automatic Review Skipped - Branch Excluded

Bito didn't auto-review because the source or target branch is excluded from automatic reviews.
No action is needed if you didn't intend for the agent to review it. Otherwise, to manually trigger a review, type /review in a comment and save.
You can change the branch exclusion settings here, or contact your Bito workspace admin at [email protected].

squiishyy
squiishyy requested changes Oct 20, 2025
View reviewed changes
flyteidl2/workflow/run_service.proto Outdated
common.TriggerName trigger_name = 6;

// Task identifier for filtering runs
task.TaskIdentifier task_id = 7;
Copy link
Contributor

@squiishyy squiishyy Oct 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also would love to add TaskName here as well as a potential filter. It is the same value was underneath the hood just without the version field. We should built this functionality in now as we will likely want it in the future :)

Copy link
Contributor Author

@popojk popojk Oct 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@squiishyy Yup! Just added TaskName here as a filter. I will wait for this PR to be merged first and the main PR will checkout to the latest commit hash of flyte2 submodule.

@popojk
update protos
96af5f7 
Signed-off-by: Alex Wu <[email protected]>
@popojk popojk requested a review from squiishyy October 21, 2025 02:47
@flyte-bot
Copy link
Collaborator

flyte-bot commented Oct 21, 2025

Bito Automatic Review Skipped - Branch Excluded

Bito didn't auto-review because the source or target branch is excluded from automatic reviews.
No action is needed if you didn't intend for the agent to review it. Otherwise, to manually trigger a review, type /review in a comment and save.
You can change the branch exclusion settings here, or contact your Bito workspace admin at [email protected].

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@machichima machichima machichima approved these changes

@squiishyy squiishyy Awaiting requested review from squiishyy

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@popojk @flyte-bot @machichima @squiishyy