Skip to content

fix proto #6685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: v2
Choose a base branch
from
Open

fix proto #6685

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7a184a5
fix proto
popojk Oct 20, 2025
96af5f7
update protos
popojk Oct 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions flyteidl2/workflow/run_service.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,6 +200,9 @@ message ListRunsRequest {

// List runs created from a trigger.
common.TriggerName trigger_name = 6;

// Task identifier for filtering runs
task.TaskIdentifier task_id = 7;
Copy link
Contributor

@squiishyy squiishyy Oct 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also would love to add TaskName here as well as a potential filter. It is the same value was underneath the hood just without the version field. We should built this functionality in now as we will likely want it in the future :)

Copy link
Contributor Author

@popojk popojk Oct 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@squiishyy Yup! Just added TaskName here as a filter. I will wait for this PR to be merged first and the main PR will checkout to the latest commit hash of flyte2 submodule.

}
}

Expand Down
457 changes: 239 additions & 218 deletions gen/go/flyteidl2/workflow/run_service.pb.go
View file
Open in desktop

Large diffs are not rendered by default.

41 changes: 41 additions & 0 deletions gen/go/flyteidl2/workflow/run_service.pb.validate.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

52 changes: 26 additions & 26 deletions gen/python/flyteidl2/workflow/run_service_pb2.py
View file
Open in desktop

Large diffs are not rendered by default.

6 changes: 4 additions & 2 deletions gen/python/flyteidl2/workflow/run_service_pb2.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,16 +113,18 @@ class GetActionDataResponse(_message.Message):
def __init__(self, inputs: _Optional[_Union[_common_pb2.Inputs, _Mapping]] = ..., outputs: _Optional[_Union[_common_pb2.Outputs, _Mapping]] = ...) -> None: ...

class ListRunsRequest(_message.Message):
__slots__ = ["request", "org", "project_id", "trigger_name"]
__slots__ = ["request", "org", "project_id", "trigger_name", "task_id"]
REQUEST_FIELD_NUMBER: _ClassVar[int]
ORG_FIELD_NUMBER: _ClassVar[int]
PROJECT_ID_FIELD_NUMBER: _ClassVar[int]
TRIGGER_NAME_FIELD_NUMBER: _ClassVar[int]
TASK_ID_FIELD_NUMBER: _ClassVar[int]
request: _list_pb2.ListRequest
org: str
project_id: _identifier_pb2.ProjectIdentifier
trigger_name: _identifier_pb2.TriggerName
def __init__(self, request: _Optional[_Union[_list_pb2.ListRequest, _Mapping]] = ..., org: _Optional[str] = ..., project_id: _Optional[_Union[_identifier_pb2.ProjectIdentifier, _Mapping]] = ..., trigger_name: _Optional[_Union[_identifier_pb2.TriggerName, _Mapping]] = ...) -> None: ...
task_id: _task_definition_pb2.TaskIdentifier
def __init__(self, request: _Optional[_Union[_list_pb2.ListRequest, _Mapping]] = ..., org: _Optional[str] = ..., project_id: _Optional[_Union[_identifier_pb2.ProjectIdentifier, _Mapping]] = ..., trigger_name: _Optional[_Union[_identifier_pb2.TriggerName, _Mapping]] = ..., task_id: _Optional[_Union[_task_definition_pb2.TaskIdentifier, _Mapping]] = ...) -> None: ...

class ListRunsResponse(_message.Message):
__slots__ = ["runs", "token"]
Expand Down
31 changes: 11 additions & 20 deletions gen/rust/Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading