NEW (eslint): @W-16113413@ Add configuration abilities to eslint engine #40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephen-carter-at-sf
force-pushed
the
sc/W-16113413
branch
from
d6217d9 to
ca14b44
Compare
jag-j
reviewed
Jul 9, 2024
stephen-carter-at-sf
force-pushed
the
sc/W-16113413
branch
from
b62d887 to
979acbb
Compare
jag-j
approved these changes
Jul 10, 2024
jfeingold35
reviewed
Jul 10, 2024
| }); | ||
|
|
||
| it('When strings are provided which are not absolute paths that share a common root folder, then return null', () => { | ||
| expect(calculateLongestCommonParentFolderOf(['oops', 'nope'])).toStrictEqual(null); |
There was a problem hiding this comment.
Could you add a comment explaining why we chose to return null, instead of an empty string or throwing an error?
There was a problem hiding this comment.
See the comment on the calcualteLongestCommonParentFolderOf ... but i'll update it even more in the next PR with:
/**
* Returns the longest common parent folder of the provided paths.
*
* @param paths It is assumed that paths is a non-empty array of absolute value paths.
* If empty or if no common parent folder exists (like in the case on Windows machines of using two different drives
* C: and D:) then null is returned (to allow the client of this function to handle this case without needing try/catch)
*/
| testInvalidLineOrColumnScenario(1, 3.124, 3, 4, 'startColumn', 3.124); | ||
| testInvalidLineOrColumnScenario(1, 2, -1.2, 4, 'endLine', -1.2); | ||
| testInvalidLineOrColumnScenario(1, 2, 3, 0, 'endColumn', 0); | ||
| it("When an engine returns a code location that has an invalid line or column, then an error is thrown", async () => { |
There was a problem hiding this comment.
Could you rewrite this test to use it.each()?
There was a problem hiding this comment.
Sure.
| getMessage('ConfigPathValueDoesNotExist','engines.dummy.some_field2', path.resolve(process.cwd(), 'doesNotExist'))); | ||
| }); | ||
|
|
||
| it("When calling extractFolder on a field that is a folder, then error", () => { |
There was a problem hiding this comment.
"field that is a file"?
There was a problem hiding this comment.
Good catch. Will fix in next PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains: