Skip to content

Add Chat Completions streaming support #391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

declark1
Copy link
Collaborator

@declark1 declark1 commented May 6, 2025

This PR adds support for streaming chat completions detection. Also updates/fixes some OpenAI types. Integration tests will be added in a separate PR.

Notes:

Closes #304

@declark1 declark1 force-pushed the chat-completions-streaming branch 3 times, most recently from 2c3a800 to 3000aa0 Compare May 13, 2025 19:31
@declark1 declark1 changed the title Chat Completions Detection - Streaming (WIP) Chat Completions Detection - Streaming May 13, 2025
@declark1 declark1 force-pushed the chat-completions-streaming branch 5 times, most recently from aa2166a to fd12ba1 Compare May 15, 2025 14:02
@declark1 declark1 force-pushed the chat-completions-streaming branch from 5a1fa29 to db60361 Compare May 30, 2025 19:07
@declark1 declark1 mentioned this pull request May 30, 2025
@declark1 declark1 marked this pull request as ready for review May 30, 2025 19:41
@declark1 declark1 force-pushed the chat-completions-streaming branch from db60361 to eab10ba Compare May 30, 2025 19:55
@declark1 declark1 changed the title Chat Completions Detection - Streaming Add Chat Completions streaming support Jun 2, 2025
@mdevino mdevino mentioned this pull request Jun 2, 2025
Signed-off-by: declark1 <[email protected]>
Copy link
Collaborator

@evaline-ju evaline-ju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few relatively minor comments

@declark1 declark1 force-pushed the chat-completions-streaming branch from 2c1fefd to c02bc1a Compare June 3, 2025 18:21
@gkumbhat gkumbhat mentioned this pull request Jun 3, 2025
@declark1 declark1 force-pushed the chat-completions-streaming branch from 74b31c8 to c4cf52f Compare June 3, 2025 19:24
Signed-off-by: declark1 <[email protected]>
Copy link
Collaborator

@evaline-ju evaline-ju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for the updates!

@declark1 declark1 merged commit 9d695e8 into foundation-model-stack:main Jun 3, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement Handler - Chat Completions Detection - Streaming
2 participants