-
Notifications
You must be signed in to change notification settings - Fork 32
Add Chat Completions streaming support #391
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
declark1
merged 9 commits into
foundation-model-stack:main
from
declark1:chat-completions-streaming
Jun 3, 2025
Merged
Add Chat Completions streaming support #391
declark1
merged 9 commits into
foundation-model-stack:main
from
declark1:chat-completions-streaming
Jun 3, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2c3a800
to
3000aa0
Compare
aa2166a
to
fd12ba1
Compare
5a1fa29
to
db60361
Compare
Merged
Signed-off-by: declark1 <[email protected]>
db60361
to
eab10ba
Compare
Signed-off-by: declark1 <[email protected]>
Signed-off-by: declark1 <[email protected]>
…detectors case Signed-off-by: declark1 <[email protected]>
Merged
Signed-off-by: declark1 <[email protected]>
evaline-ju
reviewed
Jun 2, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few relatively minor comments
src/orchestrator/handlers/chat_completions_detection/streaming.rs
Outdated
Show resolved
Hide resolved
src/orchestrator/handlers/chat_completions_detection/streaming.rs
Outdated
Show resolved
Hide resolved
src/orchestrator/handlers/chat_completions_detection/streaming.rs
Outdated
Show resolved
Hide resolved
src/orchestrator/handlers/chat_completions_detection/streaming.rs
Outdated
Show resolved
Hide resolved
…n_stream Signed-off-by: declark1 <[email protected]>
2c1fefd
to
c02bc1a
Compare
Signed-off-by: declark1 <[email protected]>
Signed-off-by: declark1 <[email protected]>
Merged
74b31c8
to
c4cf52f
Compare
Signed-off-by: declark1 <[email protected]>
evaline-ju
approved these changes
Jun 3, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - thanks for the updates!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for streaming chat completions detection. Also updates/fixes some OpenAI types. Integration tests will be added in a separate PR.
Notes:
Closes #304