Search for additional command history on Citrix systems #1501
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…plugin function does not use them.
Schamper
requested changes
Jan 16, 2026
Comment on lines
-72
to
-73
| # Also utilize the _find_history_files function of the parent class | ||
| history_files.extend(super()._find_history_files()) |
Member
There was a problem hiding this comment.
Would you mind adding a unit test? Wouldn't removing this stop the other files from being iterated in the super commandhistory? And the Citrix files to be yielded doubly because of parse_generic_history?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #1500.