Prevent fake NTFS filesystem mounts in target-mount #1520
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Miauwkeru
changed the title
Miauwkeru
force-pushed
the
fix/prevent-fake-mounts
branch
from
4582113 to
6b21bdf
Compare
Miauwkeru
reviewed
Jan 28, 2026
Contributor
Miauwkeru
left a comment
Miauwkeru
left a comment
There was a problem hiding this comment.
Could you add a test specifically in tests/tools/test_mount.py for the desired behaviour?
Contributor
Author
|
@Miauwkeru, a test has been added for your convenience. |
Miauwkeru
requested changes
Jan 29, 2026
Comment on lines
+25
to
+29
| root = tmp_path | ||
|
|
||
| # Cleanup first (conftest creates a MockTarget- tempfile) | ||
| for item in root.iterdir(): | ||
| item.unlink() |
Contributor
There was a problem hiding this comment.
Suggested change
| root = tmp_path | |
| # Cleanup first (conftest creates a MockTarget- tempfile) | |
| for item in root.iterdir(): | |
| item.unlink() | |
| root = tmp_path / "mock_ntfs" | |
| root.mkdir() |
Instead of removing the file that gets created by target_bare fixture, it is better to just create a new directory for it instead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1519