Skip to content

Prevent fake NTFS filesystem mounts in target-mount #1520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Politie-SOC wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Prevent fake NTFS filesystem mounts in target-mount #1520

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6b21bdf
Prevent fake NTFS filesystem mounts
Politie-SOC Jan 28, 2026
954d9b1
Add test for virtual ntfs filesystem mount to test_mount.py
Politie-SOC Jan 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions dissect/target/tools/mount.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,19 @@ def main() -> int:
vnames.setdefault(basename, []).append(v)
vfs.map_file_fh(f"volumes/{fname}", v)

fake_ntfs = set()
for i, fs in enumerate(t.filesystems):
ntfs_obj = getattr(fs, "ntfs", None)

if ntfs_obj in fake_ntfs:
continue

if ntfs_obj and fs.__type__ != "ntfs":
# A non ntfs filesystem with a "ntfs" object means that add_virtual_ntfs_filesystem was used.
# The fake ntfs object is added to the filesystem after its parent.
# We will mount an entry in filesystems/ for the virtual filesystem, not for the "fake" ntfs filesystem.
fake_ntfs.add(ntfs_obj)

volumes = fs.volume if isinstance(fs.volume, list) else [fs.volume]
for volume in volumes:
default_name = f"fs_{i}"
Expand Down