Strip trailing dir separator for translated file paths in ITunesLoader #952
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #952 +/- ##
==========================================
+ Coverage 77.69% 77.70% +0.01%
==========================================
Files 326 326
Lines 28481 28481
==========================================
+ Hits 22127 22131 +4
+ Misses 6354 6350 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Miauwkeru
requested changes
Nov 19, 2024
| @@ -288,7 +288,7 @@ def translate_file_path(domain: str, relative_path: str) -> str: | |||
| package_name = "" | |||
Contributor
There was a problem hiding this comment.
could you also make a test to show this behaviour?
Poeloe
force-pushed
the
fix/strip-translated-file-path
branch
from
ee2410a to
197f946
Compare
Miauwkeru
previously approved these changes
Dec 5, 2024
Schamper
requested changes
Dec 5, 2024
Co-authored-by: Erik Schamper <[email protected]>
Miauwkeru
previously approved these changes
Dec 5, 2024
Schamper
previously requested changes
Dec 5, 2024
Co-authored-by: Erik Schamper <[email protected]>
Miauwkeru
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #947