Skip to content

Fix post-release workflow #194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 7, 2025
Merged

Fix post-release workflow #194

merged 1 commit into from
Feb 7, 2025

Conversation

amacneil
Copy link
Contributor

@amacneil amacneil commented Feb 7, 2025

Changelog

None

Docs

None

Description

Fix git permissions in post-release workflow.

@amacneil amacneil force-pushed the adrian/fix-post-release branch 2 times, most recently from 6a8bbeb to c380088 Compare February 7, 2025 15:41
@amacneil amacneil force-pushed the adrian/fix-post-release branch 4 times, most recently from 576df6f to 0cd9878 Compare February 7, 2025 15:47
@amacneil amacneil force-pushed the adrian/fix-post-release branch from 0cd9878 to 71fb711 Compare February 7, 2025 15:52
@amacneil amacneil marked this pull request as ready for review February 7, 2025 15:53
@amacneil amacneil requested review from bryfox and gasmith February 7, 2025 16:27
Copy link
Contributor

@gasmith gasmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool. TIL about .on.release. I like the branch-and-merge strategy for draft releases too. Good stuff.

@amacneil
Copy link
Contributor Author

amacneil commented Feb 7, 2025

Yeah branch + merge is nice because it means you can test the exact release before it goes out, without any PRs unintentionally slipping in. We use that for main app too.

@amacneil amacneil merged commit 78b3c19 into main Feb 7, 2025
27 checks passed
@amacneil amacneil deleted the adrian/fix-post-release branch February 7, 2025 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants