python: implement additional ServerListener callbacks #240
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gasmith
approved these changes
Feb 25, 2025
|
I moved the live_visualization example as noted above, and tested running locally. |
bryfox
deleted the
bryan/fg-10181-python-add-subscription-advertisement-callbacks
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds additional callbacks to python's ServerListener interface:
on_subscribe,on_unsubscribe,on_client_advertise, andon_client_unadvertise.I've updated the live_visualization example to monitor subscribers. This example should be moved to
foxglove-sdk-examples; I can do so as part of this PR, but it's going to create noise, so I've left it alone for now.I did not introduce a new "channel view" type for python; there, the ID types are identical. I don't see much value in a type that differs in name only; I think the context makes it clear.