python: Consolidate schema types #260
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change didn't go as far as I thought it would when I wrote the ticket.
It turns out that the (message_encoding +
Schema
) we use for channels is really a (message_encoding +Optional[Schema]
) because channels can be schema-less. The same is not true for service request/response schemas, which are mandatory.Changes here:
SchemaDefinition
.Channel
constructor takes a message encoding and aSchema
.None
for schemaless.Schema
through theBaseChannel
constructor.I'm not thrilled with the result, but I thought I'd throw it up for review anyway. Feel free to nack.