Skip to content

rust: Demote &Arc<Channel> to &Channel #269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 4, 2025
Merged

rust: Demote &Arc<Channel> to &Channel #269

merged 1 commit into from
Mar 4, 2025

Conversation

gasmith
Copy link
Contributor

@gasmith gasmith commented Mar 4, 2025 •
edited
Loading

I think we can relax &Arc<Channel> to just &Channel in LogSink::log.

@gasmith gasmith self-assigned this Mar 4, 2025
@gasmith gasmith changed the title rust: Remove unnecessary arcs rust: Demote &Arc<Channel> to &Channel Mar 4, 2025
@gasmith gasmith requested review from eloff, jtbandes and bryfox March 4, 2025 06:12
@gasmith gasmith marked this pull request as ready for review March 4, 2025 06:14
eloff
eloff approved these changes Mar 4, 2025
View reviewed changes
Copy link
Contributor

@eloff eloff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this. The use of Arc here used to be because we did an await inside a block_on for the websocket server. Now it's all sync because we use the channels.

@gasmith gasmith merged commit 3f782c4 into main Mar 4, 2025
36 checks passed
@gasmith gasmith deleted the gasmith/less-arc branch March 4, 2025 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eloff eloff eloff approved these changes

@bryfox bryfox bryfox approved these changes

@jtbandes jtbandes Awaiting requested review from jtbandes

Assignees

@gasmith gasmith

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gasmith @eloff @bryfox