fix doc building to only build for releases #270
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sofuture
force-pushed
the
jz/fix-python-doc-building
branch
from
0204c08 to
e97a03b
Compare
bryfox
reviewed
Mar 4, 2025
| @@ -42,18 +42,6 @@ jobs: | |||
| - run: poetry run mypy . | |||
| - run: poetry run python -m unittest | |||
| working-directory: python/foxglove-sdk/python | |||
| - name: Sphinx build | |||
| run: | | |||
| poetry run sphinx-build --fail-on-warning ./python/docs _build | |||
There was a problem hiding this comment.
I think we should keep this step to ensure that docs continue to build successfully. We could rename the job if it's confusing.
There was a problem hiding this comment.
This will still build on non-release, it will not publish though:
https://github.com/foxglove/foxglove-sdk/actions/runs/13657311996/job/38179804468 this is from this PR
bryfox
approved these changes
Mar 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
None
Docs
None
Description
Fix python docs building to run only after Python release.