C/C++: add server callbacks for on_un/subscribe #274
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eloff
approved these changes
Mar 10, 2025
| }; | ||
|
|
||
| class Channel final { | ||
| public: | ||
| Channel(std::string_view topic, std::string_view messageEncoding, std::optional<Schema> schema); | ||
| Channel( | ||
| const std::string& topic, const std::string& messageEncoding, std::optional<Schema> schema |
There was a problem hiding this comment.
The other option is change the C api to take string pointer and length for each argument, but all our strings are pretty short here, null-terminated strings are fine.
There was a problem hiding this comment.
yeah - I guess I had two thoughts on that:
const char*(null terminated) seems pretty normal/expected for a C API- if we passed pointer+length, on the Rust side then we wouldn't be able to use
CStr::from_ptr, which is not the end of the world, but on the other hand this is exactly what it's designed for.
And another one: because C++ is stupid, technically you can also have a std::string that contains null bytes, so I think I'm viewing this API more as "advice" that the strings you pass in should be null-terminated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
Docs
N/A
Description
In addition to the features mentioned above:
string_viewtostringbecause I learned thatstring_viewis not necessarily null-terminated, but on the Rust side we assume it is