Skip to content

C/C++: run sanitizers in CI #282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Mar 12, 2025
Merged

Conversation

jtbandes
Copy link
Member

@jtbandes jtbandes commented Mar 12, 2025

Changelog

None

Docs

None

Description

Resolves FG-10685

Runs tests under ASan+UBSan, TSan, and MSan. (ASan, TSan, and MSan are mutually exclusive)

  • Turns out the Memory Sanitizer is known to have issues/false positives unless you compile everything with it enabled, including the c++ standard library, so I excluded it.
  • Turns out the Thread Sanitizer raises some false (or at least annoying, non-actionable) warnings in tokio code, and I can't figure out how to selectively disable those, so I excluded it as well.

Sanitizers can be run manually with e.g. make SANITIZE=thread test

Copy link

linear bot commented Mar 12, 2025

@jtbandes jtbandes merged commit 61b5f64 into main Mar 12, 2025
37 checks passed
@jtbandes jtbandes deleted the jacob/fg-10685-cc-run-sanitizers-in-ci branch March 12, 2025 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants