C/C++: client publishing support #287
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ent-publishing-support
…ent-publishing-support
gasmith
approved these changes
Mar 18, 2025
eloff
approved these changes
Mar 19, 2025
| const char *FOXGLOVE_NONNULL encoding; | ||
| const char *FOXGLOVE_NONNULL schema_name; | ||
| const char *schema_encoding; | ||
| const void *schema; |
There was a problem hiding this comment.
Do people use void * in C instead of byte * ?
There was a problem hiding this comment.
As far as I know C doesn't have a byte type (only C++ has std::byte) - so yes. As one example, memcpy is
void *memcpy(void *restrict dst, const void *restrict src, size_t n);
jtbandes
added a commit
that referenced
this pull request
Mar 20, 2025
### Changelog None ### Docs None ### Description I meant to include this in #287, but forgot to actually push the last commit before merging...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
C/C++: added callbacks for client advertise, publish, and unadvertise
Docs
None
Description
Depends on #286Ran into some annoyances with exposing the capability flags with cbindgen...let me know if you have any better ideas!