rust: Add SinkId for identifying sinks #290
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 14, 2025
jtbandes
approved these changes
Mar 14, 2025
|
Where is the actual comparison happening (and generally who is going to be using this)? |
It's primarily for internal use. Currently, |
eloff
approved these changes
Mar 15, 2025
gasmith
force-pushed
the
gasmith/fg-10743-subscr
branch
from
9bd1af0 to
5a973fa
Compare
gasmith
force-pushed
the
gasmith/fg-10746-sink-id
branch
from
7e07e95 to
4fb5fa9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
SinkIdand new mandatorySink::id()trait method.Description
We've been using Arc pointers to compare log sinks, which is… fine. But it'd be a bit nicer if we just had a SinkId to use, like we have a ChannelId. That would give us a natural way of indexing sinks, which will be useful for both sink deregistration as well as subscription management.