Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert index data time to rostime on bag write #7

Closed
wants to merge 1 commit into from

Conversation

klane
Copy link

@klane klane commented Nov 7, 2024

The reader converts index data time from rostime here. However, the writer does not convert it to rostime.

@klane klane changed the title Convert index data time to rostime Convert index data time to rostime on bag write Nov 7, 2024
@defunctzombie
Copy link
Contributor

@klane For clarity on the issue - what problem does this cause because the conversion is not happing on the writer?

@klane
Copy link
Author

klane commented Nov 7, 2024

@defunctzombie We have some downstream Python code that reads bags using the rosbags library. It assumes index data times are in rostime format. As is, messages come in unordered with incorrect times. Converting times in the writer resolves this for us.

@james-rms
Copy link

@klane thanks for finding this! I've created a PR here which includes this change, a test and some doc changes to clarify, closing this one in favor of that.

@james-rms james-rms closed this Nov 8, 2024
@klane klane deleted the rostime-index branch November 8, 2024 04:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants