Skip to content

Problem with allowed assets #346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rafal-gorecki opened this issue Apr 14, 2025 · 2 comments · May be fixed by #347
Open

Problem with allowed assets #346

rafal-gorecki opened this issue Apr 14, 2025 · 2 comments · May be fixed by #347
Labels
bug Something isn't working foxglove-bridge

Comments

@rafal-gorecki
Copy link

First of all, I would like to congratulate you on a piece of code well done!

Issue description:
I've been playing around with Luxonis cameras and foxglove-bridge recently. I've noticed an unusual URDF error. After analyzing it, I've come to the source of the problem.

In the default launch, only paths containing only word characters, without dashes, are allowed. However, in the depthai_desctiption package, the model files contain underscores in the file name, which causes an error.

I suggest changing the default settings in the launch file from the current

  <arg name="asset_uri_allowlist"       default="['^package://(?:\\w+/)*\\w+\\.(?:dae|fbx|glb|gltf|jpeg|jpg|mtl|obj|png|stl|tif|tiff|urdf|webp|xacro)$']" />

to

  <arg name="asset_uri_allowlist"       default="'[^package://(?:[-\\w]+/)*[-\\w]+\\.(?:dae|fbx|glb|gltf|jpeg|jpg|mtl|obj|png|stl|tif|tiff|urdf|webp|xacro)$']" />

I'm not sure if this has any potential downsides, but it might save someone some debugging time in the future.

@rafal-gorecki rafal-gorecki added the bug Something isn't working label Apr 14, 2025
Copy link

linear bot commented Apr 14, 2025

@achim-k
Copy link
Collaborator

achim-k commented Apr 17, 2025

Sounds reasonable. Would you mind opening a PR?

Edit: -> #347

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working foxglove-bridge
Development

Successfully merging a pull request may close this issue.

3 participants