Skip to content

Update default asset_uri_allowlist parameter to allow dashes #347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

achim-k
Copy link
Collaborator

@achim-k achim-k commented Apr 28, 2025

Changelog

Update default asset_uri_allowlist parameter to allow dashes

Docs

None

Description

Updates the default asset_uri_allowlist parameter to support dashes in file / folder names.

Fixes #346

@achim-k achim-k requested a review from jtbandes April 28, 2025 15:15
Copy link

linear bot commented Apr 28, 2025

@achim-k
Copy link
Collaborator Author

achim-k commented Apr 28, 2025

Rolling CI jobs are failing due to undefined symbols in the fastcdr lib.

/usr/bin/python3: symbol lookup error: /opt/ros/rolling/lib/libtest_msgs__rosidl_typesupport_fastrtps_c.so: undefined symbol: _ZN8eprosima7fastcdr3Cdr9serializeEPc

This should get fixed at some point when the ros:rolling-ros-base docker image gets updated.

See also eProsima/Fast-CDR#266

Copy link
Member

@jtbandes jtbandes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the package name actually allowed to have dashes? I guess it's not harmful to allow it here, but not sure it's valid in ROS

Note to self: apparently _ is included by default in \w

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Problem with allowed assets
2 participants