Add best_effort_qos_send_buffer_limit to support bandwidth-constrained usage #340
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running the foxglove bridge in a bandwidth-constrained environment, messages may queue up in the
send_bufferresulting in dropped messages.In order to control which messages are dropped,
best_effort_qos_topic_whitelistcan be used to force some topics to be "best_effort" rather than reliable. This can be used in conjunction with a highsend_buffer_limit(for reliable messages) and a lowerbest_effort_qos_send_buffer_limitto ensurebest_effortmessages are dropped first.These changes should be backwards compatible. I have not looked into support for ROS1 as I do not have any experience with that.