Add support for arbitrary cargo subcommands #48
+105
−45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The bin artifacts are already discovered automatically by cargo
Author
|
@frewsxcv @Manishearth @robertbastian (sorry for the ping) Can this be reviewed? |
Collaborator
|
I think this is probably a good idea in the long run but I don't have the time to review this right now, sorry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
all-featuressubcommand to allow cargo-all-features to work with arbitrary cargo subcommands like Clippy and Miri.Syntax:
This also adds the
--feature-flags-lastflag to better support tools which requires a subcommand, like Miri. The flag makes cargo-all-features to put feature-related flags (--no-default-featuresand--features) after the additional cargo flags passed by the user. Thus, for example, to call Miri one could runcargo all-features --feature-flags-last miri test <OTHER MIRI FLAGS>.The old binaries haven't been removed.
Fixes #5
Fixes #15
Fixes #26