Move metadata fetching to get_metadata method #517
+8
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor metadata retrieval into a separate method. No reason to fetch metadata synchronously when creating the AzureBlobFile object. Still enables metadata fetching using the new get_metadata method
Author
|
I submitted a fix for a typo in my previous commit on this PR. Can you please run the tests again |
Author
|
I see the tests are failing but with no explanation. It just says Is there a way to see why this is failing? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor metadata retrieval into a separate method. No reason to fetch metadata synchronously when creating the
AzureBlobFileobject. Still enables metadata fetching using the newget_metadatamethod.This saves about ~50ms per file open.
Generally synchronous calls are avoided without the user specifically requesting them. Therefore there is no reason to perform a sync call every time an object is created.