Skip to content

Move metadata fetching to get_metadata method #517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Move metadata fetching to get_metadata method #517

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
baa28eb
Move metadata fetching to get_metadata method
benjaminkaplan Nov 4, 2025
68e0af4
Fix get_metadata method definition to include self
benjaminkaplan Nov 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions adlfs/spec.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2028,21 +2028,21 @@ def __init__(
size=self.size,
**cache_options,
)
self.metadata = sync(
self.loop,
get_blob_metadata,
self.container_client,
self.blob,
version_id=self.version_id,
)

else:
self.metadata = metadata or {"is_directory": "false"}
self.buffer = io.BytesIO()
self.offset = None
self.forced = False
self.location = None

def get_metadata(self):
return self.metadata or sync(self.loop,
get_blob_metadata,
self.container_client,
self.blob,
version_id=self.version_id,
)

def _get_loop(self):
try:
# Need to confirm there is an event loop running in
Expand Down
Loading