Fixes for Love 11 #17
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@coltonoscopy Can you get this PR merged for various bug fixes? |
vaibhavarora14
approved these changes
Aug 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3
Fixes #8
Fixes #12
Fixes #14
This PR makes the game compatible with Love version 11, which is what you get if you download the framework now.
One thing that does not work anymore is setting RGBA color components with integers between 0 and 255. Relevant methods now require floats between 0 and 1, and that's addressed in 2a4ab88 for
graphics.clear. Note that the call tographics.setColorshould also be modified in the same way, but since Love seems to clip overflowing values to 1, the specific calls used here work as expected (if anyone tries a different color, though, they will likely hit the bug).The other commit makes sure all versions of the game use a love11-aware version of Push (older versions make the game crash). The one in
pong-finalis OK, so I just had all main files import that one.