Replace join_paths with cmake_path(APPEND) #498
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Steve Peters <[email protected]>
Signed-off-by: Steve Peters <[email protected]>
scpeters
commented
May 1, 2025
| cmake_path(APPEND "\${prefix}" "${CMAKE_INSTALL_LIBDIR}" | ||
| OUTPUT_VARIABLE GZ_PC_LIBDIR) | ||
| cmake_path(APPEND "\${prefix}" "${CMAKE_INSTALL_INCLUDEDIR}" "${GZ_INCLUDE_INSTALL_DIR_POSTFIX}" | ||
| OUTPUT_VARIABLE GZ_PC_INCLUDEDIR) |
There was a problem hiding this comment.
this doesn't actually work the same
before this change gz-cmake4.pc has the following line:
includedir=${prefix}/include/gz/cmake4
and after this change it is
includedir=include/gz/cmake4
I think the first argument to cmake_path(APPEND needs to be a cmake variable, not an expression that is meant to be evaluated at pkg-config runtime. I'm not sure how to use cmake_path(APPEND in this case
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Fixes a cleanup comment
Summary
There is a TODO comment suggesting that we use
cmake_path(APPEND)when cmake 3.20 is required. Since Ionic uses cmake 3.22.1, we can make this change now.Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.