Feature/take optional kernel_mean_row_sum in refine() #266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tp832944 thanks in advance for your review. This unit tests are currently failing, and I believe this is down to circular imports. Unfortunately, I haven't been able to resolve this. |
tp832944
requested changes
Dec 1, 2023
coreax/refine.py
Outdated
| :param kernel_mean_row_sum: (Optional) Mean vector over rows for the Gram matrix, | ||
| a :math:`1 \times n` array. If this variable has been pre-calculated, pass | ||
| it to refine() to reduce computational load. If this variable is passed, | ||
| ```self.approximate_kernel_row_sum` is ignored. |
There was a problem hiding this comment.
Only one opening quote.
Copy this edit into each of the three concrete classes.
There was a problem hiding this comment.
Sorry, I got this one wrong. It should be
:attr:`approximate_kernel_row_sum`No self.
9 tasks
tp832944
reviewed
Dec 6, 2023
tp832944
reviewed
Dec 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #264
PR Type
Description
Refine.refine()currently calculateskernel_mean_row_sumwith no option to use an already-calculated value. This PR adds this as an optional argument torefine(), taking a default value ofNoneto indicate that it still needs to be calculated.How Has This Been Tested?
No formal testing. Current refine.py unit tests need to be extended to reflect the changes.
Does this PR introduce a breaking change?
No.
Screenshots
(Write your answer here.)
Checklist before requesting a review