Skip to content

Feature/take optional kernel_mean_row_sum in refine() (new) #274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Feature/take optional kernel_mean_row_sum in refine() (new) #274

wants to merge 1 commit into from

Conversation

bk958178
Copy link
Contributor

@bk958178 bk958178 commented Dec 6, 2023 •
edited
Loading

Refs #264

PR Type

  • Feature

Description

This PR adds kernel_mean_row_sum as an optional argument to refine(), enabling caching of this variable.

This PR mirrors the changes made on #266. This PR is created with the aim of a cleaner merge of the changes into the base branch.

How Has This Been Tested?

No formal testing. Current refine.py unit tests need to be extended to reflect the changes.

Does this PR introduce a breaking change?

No.

Screenshots

Checklist before requesting a review

  • I have made sure that my PR is not a duplicate.
  • My code follows the style guidelines of this project.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have performed a self-review of my code.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • Any dependent changes have been merged and published in downstream modules.

@bk958178 bk958178 mentioned this pull request Dec 6, 2023
Merged
9 tasks
@bk958178 bk958178 requested a review from tp832944 December 6, 2023 14:20
@bk958178 bk958178 changed the title Feature/refine takes k mean row sum (new) Feature/take optional kernel_mean_row_sum in refine() (new) Dec 6, 2023
@bk958178 bk958178 changed the base branch from main to feature/oop_106 December 6, 2023 14:21
@bk958178 bk958178 closed this Dec 6, 2023
@tp832944 tp832944 deleted the feature/new_refine_takes_k_mean_row_sum branch January 16, 2024 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tp832944 tp832944 Awaiting requested review from tp832944

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@bk958178