Skip to content

Various improvements in Django views for impact and aelo #10868

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 15 commits into
base: master
Choose a base branch
from
Open

Various improvements in Django views for impact and aelo #10868

wants to merge 15 commits into from

Conversation

ptormene
Copy link
Member

@ptormene ptormene commented Oct 9, 2025 •
edited
Loading

  • adding display names for asce41_sa_final and spectra_asce41
  • displaying notifications (notes and warnings, if present) also on top of the standard (i.e. the "advanced") outputs page
  • refactoring the view for the standard outputs page, to pass to the page only variables that are relevant with respect to the current application mode, and grouping all images into a pngs dictionary
  • adding cross-validation in case both the site class and the Vs30 are specified (needed when the API is used programmatically)

@ptormene ptormene added this to the Engine 3.24.0 milestone Oct 9, 2025
@ptormene ptormene self-assigned this Oct 9, 2025
@ptormene ptormene added enhancement AELO PR for the AELO project or affecting the AELO numbers labels Oct 9, 2025
ptormene
ptormene commented Oct 9, 2025
View reviewed changes
openquake/calculators/export/__init__.py
'asce07': 'ASCE 7 Parameters',
'asce41': 'ASCE 41 Parameters',
'asce41_sa_final': 'ASCE41 BSE Spectra',
'spectra_asce41': 'ASCE41 Calculations',
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm using the display names suggested by @ManuelaVillani. Please @kejohnso double-check if they look fine to you as well.

@ptormene
Group images under 'pngs' also in outputs_aelo
ab3a778
@ptormene
Remove initialization of variables that went under the 'pngs' dict
3f6cd36
@ptormene
Fix a docstring [ci skip]
5000c5c
@ptormene
Merge remote-tracking branch 'origin/master' into notifications_colle…
a142b89 
…ctargs
@ptormene
Raise a validation error if the site class is not 'custom' and the gi…
247842e 
…ven Vs30 is not the expected one corresponding to the chosen site class (possible if calling the aelo_run API endpoint)
@ptormene
Cross-check site_class and vs30 only when the site class is specified
66d2fc4
@ptormene
Merge remote-tracking branch 'origin/master' into notifications_colle…
798ba35 
…ctargs
@ptormene
Merge remote-tracking branch 'origin/master' into notifications_colle…
822b199 
…ctargs
@ptormene
Merge remote-tracking branch 'origin/master' into notifications_colle…
ed3775a 
…ctargs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@micheles micheles Awaiting requested review from micheles

@kejohnso kejohnso Awaiting requested review from kejohnso

@ManuelaVillani ManuelaVillani Awaiting requested review from ManuelaVillani

Assignees

@ptormene ptormene

Labels

AELO PR for the AELO project or affecting the AELO numbers enhancement

Projects

None yet

Milestone

Engine 3.24.0

Development

Successfully merging this pull request may close these issues.

1 participant

@ptormene