-
Notifications
You must be signed in to change notification settings - Fork 299
Various improvements in Django views for impact and aelo #10868
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ptormene
wants to merge
15
commits into
master
Choose a base branch
from
notifications_collectargs
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 6 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
35ba9e9
In web_engine_get_outputs pass to the template only data that is rele…
ptormene ad4ad35
Add display names for asce41_sa_final and spectra_asce41
ptormene af51118
Extract function get_aelo_notes_and_warnings and display notification…
ptormene a681acc
Merge branch 'collectargs' into notifications_collectargs
ptormene 70bd847
Display impact warnings in both advanced and simplified outputs pages
ptormene 6f7ed8f
Merge remote-tracking branch 'origin/master' into notifications_colle…
ptormene ab3a778
Group images under 'pngs' also in outputs_aelo
ptormene 3f6cd36
Remove initialization of variables that went under the 'pngs' dict
ptormene 5000c5c
Fix a docstring [ci skip]
ptormene a142b89
Merge remote-tracking branch 'origin/master' into notifications_colle…
ptormene 247842e
Raise a validation error if the site class is not 'custom' and the gi…
ptormene 66d2fc4
Cross-check site_class and vs30 only when the site class is specified
ptormene 798ba35
Merge remote-tracking branch 'origin/master' into notifications_colle…
ptormene 822b199
Merge remote-tracking branch 'origin/master' into notifications_colle…
ptormene ed3775a
Merge remote-tracking branch 'origin/master' into notifications_colle…
ptormene File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm using the display names suggested by @ManuelaVillani. Please @kejohnso double-check if they look fine to you as well.