RFC2231 header parameter-value encoding #311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Was surprized it did not trigger proper test failure, but it seems we don't generate long or non-ascii header parameter values. gen_smtp/test/prop_mimemail.erl Line 396 in c6f25a7 Might be nice to update when parser part is also implemented. I'll have a deeper look bit later today, thank you! |
Maria-12648430
force-pushed
the
param_encoding_rfc2231
branch
from
2e756b4
to
5d92d66
Compare
|
Last commit takes care of an edge case: invalid UTF-8 sequences were not encoded but left as-is. |
|
@seriyps Ok to merge this? |
Closed
seriyps
approved these changes
Dec 22, 2022
|
Great work! Sorry for the delay, it was due to UA-RU war. |
|
@seriyps thanks 😄 TBH, I totally forgot about this one 😅 |
mworrell
approved these changes
Jan 10, 2023
Co-authored-by: Jan Uhlig <[email protected]>
Maria-12648430
force-pushed
the
param_encoding_rfc2231
branch
from
5d92d66
to
330ed53
Compare
|
@seriyps I am ok with this being merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As pointed out in #310, parameters are supposed to be encoded according to RFC2231, not RFC2047.
The value is first analyzed to decide which representation can/must be used, based on the presence of CTLs, spaces, tspecials, and UTF-8 multibyte characters. Then it is encoded in the selected representation. If the parameter lines become too long (>76 bytes), they are split up according to the continuation scheme described in RFC2231.
In hindsight, getting this right was surprisingly difficult, and therefore a careful review seems to be called for.