Skip to content

Fix wrong query parameter key used for record link generation #9074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −4
Open

Fix wrong query parameter key used for record link generation #9074

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions core/src/main/java/org/fao/geonet/kernel/datamanager/base/BaseMetadataUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -358,9 +358,9 @@ public String getPermalink(String uuid, String language) {
// Get the recordLinkFormatter from the UI configuration
String recordLinkFormatter = XslUtil.getUiConfigurationJsonProperty(null, "mods.search.formatter.recordLinkFormatter");

// If the recordLinkFormatter is defined append it to the defaultLink
// If recordLinkFormatter is configured add the recordViewFormatter query parameter
if (StringUtils.isNotBlank(recordLinkFormatter)) {
uriComponentsBuilder.queryParam("recordLinkFormatter", recordLinkFormatter);
uriComponentsBuilder.queryParam("recordViewFormatter", recordLinkFormatter);
}
}

Expand Down
4 changes: 2 additions & 2 deletions core/src/main/java/org/fao/geonet/util/LocalizedEmailComponent.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -371,9 +371,9 @@ private String replaceLinks(String message) {
.fromHttpUrl(settingManager.getNodeURL())
.pathSegment("api", "records", replaceLinksWithHtmlFormat ? "{{index:uuid}}" : "'{{'index:uuid'}}'");

// If recordLinkFormatter is configured add it as a query parameter
// If recordLinkFormatter is configured add the recordViewFormatter query parameter
if (StringUtils.isNotBlank(recordLinkFormatter)) {
uriComponentsBuilder.queryParam("recordLinkFormatter", recordLinkFormatter);
uriComponentsBuilder.queryParam("recordViewFormatter", recordLinkFormatter);
}

return message.replace("{{link}}", uriComponentsBuilder.build().toString());
Expand Down
Loading