Refactor integration tests #142
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lcian
commented
Mar 21, 2025
Comment on lines
+187
to
+198
| <execution> | ||
| <id>make-cli-executable</id> | ||
| <phase>process-resources</phase> | ||
| <goals> | ||
| <goal>run</goal> | ||
| </goals> | ||
| <configuration> | ||
| <target> | ||
| <chmod file="${project.build.outputDirectory}/bin/**" perm="755"/> | ||
| </target> | ||
| </configuration> | ||
| </execution> |
There was a problem hiding this comment.
When copied to target the binaries were not set as executable, causing the tests to fail on my machine.
This did not happen everytime, I guess it was dependent on the order of maven commands you run.
Regardless, this fixes it.
lcian
commented
Mar 21, 2025
src/test/java/io/sentry/integration/uploadSourceBundle/UploadSourceBundleTestIT.kt
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
Refactors the integration tests to have a uniform structure (package for the goal they test + dedicated
PomUtils) and updates the Makefile with a command to run them.#skip-changelog