dep(proguard): Update proguard cache format #1734
Merged
+30
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loewenheim
changed the title
olksdr
approved these changes
Jul 17, 2025
loewenheim
added a commit
that referenced
this pull request
Jul 17, 2025
Depends on #1734. This adds a field `method_synthesized` to `JvmFrame` that denotes whether the frame's method was synthesized by the compiler.
This updates the `proguard` dependency to 5.6.1 to get access to "synthesized" flags in the cache format (see getsentry/rust-proguard#52). Since the cache format has changed, this requires an _incompatible_ bump of the proguard cache version. It also adds a static version check for the cache version exposed by the `proguard` crate in analogy to symcaches and cficaches.
loewenheim
force-pushed
the
sebastian/proguard-update
branch
from
0f31478 to
29ee13d
Compare
loewenheim
added a commit
that referenced
this pull request
Jul 17, 2025
Depends on #1734. This adds a field `method_synthesized` to `JvmFrame` that denotes whether the frame's method was synthesized by the compiler.
loewenheim
commented
Jul 17, 2025
| filename: EditActivity | ||
| filename: R8$$SyntheticClass |
There was a problem hiding this comment.
This change is an effect of the improved file name resolution from getsentry/rust-proguard#55. The previous filename was incorrect.
loewenheim
added a commit
that referenced
this pull request
Jul 17, 2025
Depends on #1734. This adds a field `method_synthesized` to `JvmFrame` that denotes whether the frame's method was synthesized by the compiler.
loewenheim
added a commit
that referenced
this pull request
Jul 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the
proguarddependency to 5.6.1 to get access to "synthesized" flags in the cache format(see getsentry/rust-proguard#52).
Since the cache format has changed, this requires an incompatible bump of the proguard cache version.
It also adds a static version check for the cache version exposed by the
proguardcrate in analogy to symcaches and cficaches.ref: #1720. ref: SYMBOLI-22.