Add license scan report and status#332
Conversation
|
Your license scan is passing -- congrats! Your badge status is now updated and ready to merge: |
qmonnet
force-pushed
the
add-license-scan-badge
branch
from
ad67057 to
f431326
Compare
qmonnet
left a comment
qmonnet
left a comment
There was a problem hiding this comment.
Background context: I noticed that Sergei had enabled FOSSA on the gateway repo and asked if we could have the same for dataplane.
@daniel-noland @mvachhar any opinion for this PR? I like the badge at the top but I lean on removing the bigger picture at the end of the README, I find it too big/distracting.
I'm ok with this, remove the bigger picture at the end. Unfortunately, I don't think we can just edit this PR so we'd either have to merge it or just create a new PR with the required changes. |
qmonnet
force-pushed
the
add-license-scan-badge
branch
from
f431326 to
32267f5
Compare
But of course we can! |
qmonnet
left a comment
qmonnet
left a comment
There was a problem hiding this comment.
I removed the addition of the big picture at the bottom, keeping just the badge.
Looks good to me, although the reports look weird at the moment, it seems the bot's not scanning our repo correctly. Sergei said he'd reach out to FOSSA support about it. Let's hold on for now until it makes sense to link to the results' page.
|
Sergei says “it seems like for the rust projects it needs to be configured first time through the cli”, he'll try to look into it this week. |
|
We looked into it a little. The FOSSA CLI works (better than the quick auto-integration), we haven't looked into integrating it to a workflow yet. |
[ Quentin: Fix project path after project reimport in FOSSA,
Remove suggested picture from end of README.md,
Fixed commit title, Signed-off-by tag format ]
Signed-off-by: fossabot <badges@fossa.com>
Signed-off-by: Quentin Monnet <qmo@qmon.net>
qmonnet
force-pushed
the
add-license-scan-badge
branch
from
32267f5 to
ea2bf03
Compare
qmonnet
left a comment
qmonnet
left a comment
There was a problem hiding this comment.
We set up FOSSA appropriately for the repo, and I updated the commit with the right link (now that we've removed and reimported the dataplane repo into FOSSA). This PR to add the badge to the README is good to go 👍
3 participants
Your FOSSA integration was successful! Attached in this PR is a badge and license report to track scan status in your README.
Below are docs for integrating FOSSA license checks into your CI: