-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add license scan report and status #332
base: main
Are you sure you want to change the base?
Conversation
ad67057
to
f431326
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Background context: I noticed that Sergei had enabled FOSSA on the gateway
repo and asked if we could have the same for dataplane
.
@daniel-noland @mvachhar any opinion for this PR? I like the badge at the top but I lean on removing the bigger picture at the end of the README, I find it too big/distracting.
I'm ok with this, remove the bigger picture at the end. Unfortunately, I don't think we can just edit this PR so we'd either have to merge it or just create a new PR with the required changes. |
[ Quentin: Remove suggested picture from end of README.md, Fixed commit title, Signed-off-by tag format ] Signed-off-by: fossabot <[email protected]> Signed-off-by: Quentin Monnet <[email protected]>
f431326
to
32267f5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed the addition of the big picture at the bottom, keeping just the badge.
Looks good to me, although the reports look weird at the moment, it seems the bot's not scanning our repo correctly. Sergei said he'd reach out to FOSSA support about it. Let's hold on for now until it makes sense to link to the results' page.
Sergei says “it seems like for the rust projects it needs to be configured first time through the cli”, he'll try to look into it this week. |
We looked into it a little. The FOSSA CLI works (better than the quick auto-integration), we haven't looked into integrating it to a workflow yet. |
Your FOSSA integration was successful! Attached in this PR is a badge and license report to track scan status in your README.
Below are docs for integrating FOSSA license checks into your CI: