Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add license scan report and status #332

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

fossabot
Copy link

@fossabot fossabot commented Mar 5, 2025

Your FOSSA integration was successful! Attached in this PR is a badge and license report to track scan status in your README.

Below are docs for integrating FOSSA license checks into your CI:

@fossabot fossabot requested a review from a team as a code owner March 5, 2025 23:07
@fossabot fossabot requested review from sergeymatov and removed request for a team March 5, 2025 23:07
@fossabot
Copy link
Author

fossabot commented Mar 5, 2025

Your license scan is passing -- congrats!

Your badge status is now updated and ready to merge:

FOSSA Status

@qmonnet qmonnet self-requested a review March 6, 2025 00:24
@qmonnet qmonnet force-pushed the add-license-scan-badge branch from ad67057 to f431326 Compare March 6, 2025 09:52
Copy link
Member

@qmonnet qmonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Background context: I noticed that Sergei had enabled FOSSA on the gateway repo and asked if we could have the same for dataplane.

@daniel-noland @mvachhar any opinion for this PR? I like the badge at the top but I lean on removing the bigger picture at the end of the README, I find it too big/distracting.

@mvachhar
Copy link
Contributor

mvachhar commented Mar 7, 2025

Background context: I noticed that Sergei had enabled FOSSA on the gateway repo and asked if we could have the same for dataplane.

@daniel-noland @mvachhar any opinion for this PR? I like the badge at the top but I lean on removing the bigger picture at the end of the README, I find it too big/distracting.

I'm ok with this, remove the bigger picture at the end. Unfortunately, I don't think we can just edit this PR so we'd either have to merge it or just create a new PR with the required changes.

[ Quentin: Remove suggested picture from end of README.md,
    Fixed commit title, Signed-off-by tag format ]

Signed-off-by: fossabot <[email protected]>
Signed-off-by: Quentin Monnet <[email protected]>
@qmonnet qmonnet force-pushed the add-license-scan-badge branch from f431326 to 32267f5 Compare March 10, 2025 10:31
@qmonnet
Copy link
Member

qmonnet commented Mar 10, 2025

I don't think we can just edit this PR

image

But of course we can!

Copy link
Member

@qmonnet qmonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed the addition of the big picture at the bottom, keeping just the badge.

Looks good to me, although the reports look weird at the moment, it seems the bot's not scanning our repo correctly. Sergei said he'd reach out to FOSSA support about it. Let's hold on for now until it makes sense to link to the results' page.

@qmonnet qmonnet added the dont-merge Do not merge this Pull Request label Mar 10, 2025
@qmonnet qmonnet removed the request for review from sergeymatov March 10, 2025 10:37
@qmonnet
Copy link
Member

qmonnet commented Mar 11, 2025

Sergei says “it seems like for the rust projects it needs to be configured first time through the cli”, he'll try to look into it this week.

@qmonnet
Copy link
Member

qmonnet commented Mar 13, 2025

We looked into it a little. The FOSSA CLI works (better than the quick auto-integration), we haven't looked into integrating it to a workflow yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dont-merge Do not merge this Pull Request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants