Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake/pkgconfig: use CMAKE_INSTALL_FULL_* variables #766

Merged
merged 1 commit into from
Jul 29, 2024

Conversation

doronbehar
Copy link
Contributor

Copy link
Contributor

@jdemel jdemel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for your contribution!

@jdemel
Copy link
Contributor

jdemel commented Jul 29, 2024

Besides, cleaning up the code, does this PR fix anything in particular?

@doronbehar
Copy link
Contributor Author

Besides, cleaning up the code, does this PR fix anything in particular?

Yes. It fixes the build on NixOS. Our build system has automatic checks for pkg config files, that make sure our pkg-config files have valid paths. Not knowing the subtle difference between CMAKE_INSTALL_FULL_* variables and the variables that were used before this patch, is a common mistake detected by our build system, and without this check and this patch, the pkg config files generated by volk before this patch are incorrect.

You may be able to create an invalid path if you'd build volk with a non trivial prefix - as done in NixOS (And Guix) for every package. See: https://nixos.org/guides/how-nix-works/

@jdemel jdemel merged commit bd4694d into gnuradio:main Jul 29, 2024
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants