Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consolidate SphericalHarmonics implementations #56

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Consolidate SphericalHarmonics implementations #56

wants to merge 1 commit into from
+84 −419

Conversation

copybara-service[bot]
Copy link

@copybara-service copybara-service bot commented Nov 4, 2024 •
edited
Loading

Consolidate SphericalHarmonics implementations

  • Delete ComplexSphericalHarmonics
  • Replace the old RealSphericalHarmonics with RealSphericalHarmonicsWithZeroImag, which is what we actually use in practice (it's faster and supports parallelism)

@copybara-service copybara-service bot changed the title No public description Consolidate SphericalHarmonics implementations Nov 4, 2024
@copybara-service copybara-service bot force-pushed the test_693112634 branch 8 times, most recently from 6d1fc0f to d29be25 Compare November 6, 2024 19:54
@shoyer
Consolidate SphericalHarmonics implementations
711b873 
- Delete ComplexSphericalHarmonics
- Replace the old RealSphericalHarmonics with RealSphericalHarmonicsWithZeroImag, which is what we actually use in practice (it's faster and supports parallelism)

PiperOrigin-RevId: 693112634
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@shoyer