Reduce Go version duplication #12458
Open
+57
−71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
tamird
force-pushed
the
gpu-cleanup
branch
2 times, most recently
from
bd64cfb to
3d21ff3
Compare
This is the standard connectivity check used elsewhere.
Closed
This should make it easier to delete this code when the time comes.
Remove `images/gpu/cuda-tests-12-8/install_go.sh`; golang is already installed via apt and the version is immaterial.
avagin
reviewed
Jan 8, 2026
copybara-service bot
pushed a commit
that referenced
this pull request
Jan 8, 2026
- Use `go_sdk.from_file` instead of repeating the version encoded in `go.mod` in `MODULE.bazel`. - Remove `images/gpu/cuda-tests-12-8/install_go.sh`; golang is already installed via apt and the version is immaterial. FUTURE_COPYBARA_INTEGRATE_REVIEW=#12458 from tamird:gpu-cleanup 248b336 PiperOrigin-RevId: 853776390
Contributor
|
Yeah, the intent was just to install go to build the third party tool / the runner script (run_sample.go in this directory). This is just a test / benchmark workload...it has nothing to do with overall gVisor build / installs. I'll review this. |
copybara-service bot
pushed a commit
that referenced
this pull request
Jan 8, 2026
- **packetdrill: use docker version** This is the standard connectivity check used elsewhere. - **tools/build_cover.sh: rearrange** This should make it easier to delete this code when the time comes. - **Reduce Go version duplication** Remove `images/gpu/cuda-tests-12-8/install_go.sh`; golang is already installed via apt and the version is immaterial. FUTURE_COPYBARA_INTEGRATE_REVIEW=#12458 from tamird:gpu-cleanup 248b336 PiperOrigin-RevId: 853776390
copybara-service bot
pushed a commit
that referenced
this pull request
Jan 8, 2026
- **packetdrill: use docker version** This is the standard connectivity check used elsewhere. - **tools/build_cover.sh: rearrange** This should make it easier to delete this code when the time comes. - **Reduce Go version duplication** Remove `images/gpu/cuda-tests-12-8/install_go.sh`; golang is already installed via apt and the version is immaterial. FUTURE_COPYBARA_INTEGRATE_REVIEW=#12458 from tamird:gpu-cleanup 248b336 PiperOrigin-RevId: 853776390
Contributor
Author
|
@zkoopmans I pushed two more commits, please have a look. We now use multi-stage builds for these Go programs, which gives us version stability without requiring either |
Collaborator
Thanks for your perseverance @tamird, I think this is quite neat. |
copybara-service bot
pushed a commit
that referenced
this pull request
Jan 8, 2026
- **packetdrill: use docker version** This is the standard connectivity check used elsewhere. - **tools/build_cover.sh: rearrange** This should make it easier to delete this code when the time comes. - **Reduce Go version duplication** Remove `images/gpu/cuda-tests-12-8/install_go.sh`; golang is already installed via apt and the version is immaterial. - **cuda-tests: make Dockerfiles more similar** These files are *almost* identical. Go the rest of the way. Now the only difference is the invocation of `cmake`. - **Dockerfile: use golang builder images** This avoids the need for `apt-get install golang` and other shenanigans. It also makes it clear that the version of Go used need not track the version specified in `go.mod`. FUTURE_COPYBARA_INTEGRATE_REVIEW=#12458 from tamird:gpu-cleanup 6abf014 PiperOrigin-RevId: 853776390
copybara-service bot
pushed a commit
that referenced
this pull request
Jan 8, 2026
- **packetdrill: use docker version** This is the standard connectivity check used elsewhere. - **tools/build_cover.sh: rearrange** This should make it easier to delete this code when the time comes. - **Reduce Go version duplication** Remove `images/gpu/cuda-tests-12-8/install_go.sh`; golang is already installed via apt and the version is immaterial. - **cuda-tests: make Dockerfiles more similar** These files are *almost* identical. Go the rest of the way. Now the only difference is the invocation of `cmake`. - **Dockerfile: use golang builder images** This avoids the need for `apt-get install golang` and other shenanigans. It also makes it clear that the version of Go used need not track the version specified in `go.mod`. FUTURE_COPYBARA_INTEGRATE_REVIEW=#12458 from tamird:gpu-cleanup 6abf014 PiperOrigin-RevId: 853776390
These files are *almost* identical. Go the rest of the way. Now the only difference is the invocation of `cmake`.
Contributor
Author
|
Oops, |
ayushr2
approved these changes
Jan 8, 2026
tamird
force-pushed
the
gpu-cleanup
branch
2 times, most recently
from
c4222a8 to
6da3c38
Compare
Contributor
Author
|
Oops almost had it right, and now it is actually right. |
copybara-service bot
pushed a commit
that referenced
this pull request
Jan 8, 2026
- **packetdrill: use docker version** This is the standard connectivity check used elsewhere. - **tools/build_cover.sh: rearrange** This should make it easier to delete this code when the time comes. - **Reduce Go version duplication** Remove `images/gpu/cuda-tests-12-8/install_go.sh`; golang is already installed via apt and the version is immaterial. - **cuda-tests: make Dockerfiles more similar** These files are *almost* identical. Go the rest of the way. Now the only difference is the invocation of `cmake`. - **Dockerfile: use golang builder images** This avoids the need for `apt-get install golang` and other shenanigans. It also makes it clear that the version of Go used need not track the version specified in `go.mod`. FUTURE_COPYBARA_INTEGRATE_REVIEW=#12458 from tamird:gpu-cleanup 6abf014 PiperOrigin-RevId: 853776390
copybara-service bot
pushed a commit
that referenced
this pull request
Jan 8, 2026
- **packetdrill: use docker version** This is the standard connectivity check used elsewhere. - **tools/build_cover.sh: rearrange** This should make it easier to delete this code when the time comes. - **Reduce Go version duplication** Remove `images/gpu/cuda-tests-12-8/install_go.sh`; golang is already installed via apt and the version is immaterial. - **cuda-tests: make Dockerfiles more similar** These files are *almost* identical. Go the rest of the way. Now the only difference is the invocation of `cmake`. - **Dockerfile: use golang builder images** This avoids the need for `apt-get install golang` and other shenanigans. It also makes it clear that the version of Go used need not track the version specified in `go.mod`. FUTURE_COPYBARA_INTEGRATE_REVIEW=#12458 from tamird:gpu-cleanup 6da3c38 PiperOrigin-RevId: 853776390
copybara-service bot
pushed a commit
that referenced
this pull request
Jan 8, 2026
- **packetdrill: use docker version** This is the standard connectivity check used elsewhere. - **tools/build_cover.sh: rearrange** This should make it easier to delete this code when the time comes. - **Reduce Go version duplication** Remove `images/gpu/cuda-tests-12-8/install_go.sh`; golang is already installed via apt and the version is immaterial. - **cuda-tests: make Dockerfiles more similar** These files are *almost* identical. Go the rest of the way. Now the only difference is the invocation of `cmake`. - **Dockerfile: use golang builder images** This avoids the need for `apt-get install golang` and other shenanigans. It also makes it clear that the version of Go used need not track the version specified in `go.mod`. FUTURE_COPYBARA_INTEGRATE_REVIEW=#12458 from tamird:gpu-cleanup 6da3c38 PiperOrigin-RevId: 853776390
copybara-service bot
pushed a commit
that referenced
this pull request
Jan 8, 2026
- **packetdrill: use docker version** This is the standard connectivity check used elsewhere. - **tools/build_cover.sh: rearrange** This should make it easier to delete this code when the time comes. - **Reduce Go version duplication** Remove `images/gpu/cuda-tests-12-8/install_go.sh`; golang is already installed via apt and the version is immaterial. - **cuda-tests: make Dockerfiles more similar** These files are *almost* identical. Go the rest of the way. Now the only difference is the invocation of `cmake`. - **Dockerfile: use golang builder images** This avoids the need for `apt-get install golang` and other shenanigans. It also makes it clear that the version of Go used need not track the version specified in `go.mod`. FUTURE_COPYBARA_INTEGRATE_REVIEW=#12458 from tamird:gpu-cleanup 6da3c38 PiperOrigin-RevId: 853776390
This avoids the need for `apt-get install golang` and other shenanigans. It also makes it clear that the version of Go used need not track the version specified in `go.mod`.
Contributor
Author
|
Another buglet, this time it was |
copybara-service bot
pushed a commit
that referenced
this pull request
Jan 8, 2026
- **packetdrill: use docker version** This is the standard connectivity check used elsewhere. - **tools/build_cover.sh: rearrange** This should make it easier to delete this code when the time comes. - **Reduce Go version duplication** Remove `images/gpu/cuda-tests-12-8/install_go.sh`; golang is already installed via apt and the version is immaterial. - **cuda-tests: make Dockerfiles more similar** These files are *almost* identical. Go the rest of the way. Now the only difference is the invocation of `cmake`. - **Dockerfile: use golang builder images** This avoids the need for `apt-get install golang` and other shenanigans. It also makes it clear that the version of Go used need not track the version specified in `go.mod`. FUTURE_COPYBARA_INTEGRATE_REVIEW=#12458 from tamird:gpu-cleanup 6da3c38 PiperOrigin-RevId: 853776390
copybara-service bot
pushed a commit
that referenced
this pull request
Jan 8, 2026
- **packetdrill: use docker version** This is the standard connectivity check used elsewhere. - **tools/build_cover.sh: rearrange** This should make it easier to delete this code when the time comes. - **Reduce Go version duplication** Remove `images/gpu/cuda-tests-12-8/install_go.sh`; golang is already installed via apt and the version is immaterial. - **cuda-tests: make Dockerfiles more similar** These files are *almost* identical. Go the rest of the way. Now the only difference is the invocation of `cmake`. - **Dockerfile: use golang builder images** This avoids the need for `apt-get install golang` and other shenanigans. It also makes it clear that the version of Go used need not track the version specified in `go.mod`. FUTURE_COPYBARA_INTEGRATE_REVIEW=#12458 from tamird:gpu-cleanup ba07231 PiperOrigin-RevId: 853776390
copybara-service bot
pushed a commit
that referenced
this pull request
Jan 9, 2026
- **packetdrill: use docker version** This is the standard connectivity check used elsewhere. - **tools/build_cover.sh: rearrange** This should make it easier to delete this code when the time comes. - **Reduce Go version duplication** Remove `images/gpu/cuda-tests-12-8/install_go.sh`; golang is already installed via apt and the version is immaterial. - **cuda-tests: make Dockerfiles more similar** These files are *almost* identical. Go the rest of the way. Now the only difference is the invocation of `cmake`. - **Dockerfile: use golang builder images** This avoids the need for `apt-get install golang` and other shenanigans. It also makes it clear that the version of Go used need not track the version specified in `go.mod`. FUTURE_COPYBARA_INTEGRATE_REVIEW=#12458 from tamird:gpu-cleanup ba07231 PiperOrigin-RevId: 853776390
copybara-service bot
pushed a commit
that referenced
this pull request
Jan 9, 2026
- **packetdrill: use docker version** This is the standard connectivity check used elsewhere. - **tools/build_cover.sh: rearrange** This should make it easier to delete this code when the time comes. - **Reduce Go version duplication** Remove `images/gpu/cuda-tests-12-8/install_go.sh`; golang is already installed via apt and the version is immaterial. - **cuda-tests: make Dockerfiles more similar** These files are *almost* identical. Go the rest of the way. Now the only difference is the invocation of `cmake`. - **Dockerfile: use golang builder images** This avoids the need for `apt-get install golang` and other shenanigans. It also makes it clear that the version of Go used need not track the version specified in `go.mod`. FUTURE_COPYBARA_INTEGRATE_REVIEW=#12458 from tamird:gpu-cleanup ba07231 PiperOrigin-RevId: 853776390
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the standard connectivity check used elsewhere.
This should make it easier to delete this code when the time comes.
Remove
images/gpu/cuda-tests-12-8/install_go.sh; golang is alreadyinstalled via apt and the version is immaterial.
These files are almost identical. Go the rest of the way. Now the only
difference is the invocation of
cmake.This avoids the need for
apt-get install golangand other shenanigans.It also makes it clear that the version of Go used need not track the
version specified in
go.mod.