-
Notifications
You must be signed in to change notification settings - Fork 76
make tfhe-rs a bazel dependency #1743
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Oops. Now the old cargo | Filecheck tests are giving me this error:
|
Yeah, for the FPGA tests I run them locally on the FPGA server (so really a copy past approach). Normally, the FPGA code in HEIR should represent the small testbench that we can use it from. |
9547d3d
to
38ce0b7
Compare
Go ahead and delete heir/.github/workflows/build_and_test.yml Lines 78 to 86 in e70b591
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nicely done! Just a few nits, hopefully implying more deletion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool! Thanks
Maybe something we should discuss during one of the meetings is how we see the FPGA testings and if we even want the run results (since the outputted code is the same as CPU code)
96d6c4a
to
7642df8
Compare
Signed-off-by: Asra Ali <[email protected]> fix sbox timeout Signed-off-by: Asra Ali <[email protected]> remove test files Signed-off-by: Asra Ali <[email protected]> address comments Signed-off-by: Asra Ali <[email protected]> remove unneeded deps Signed-off-by: Asra Ali <[email protected]>
FPGA tests:
Left the Cargo.toml with the local tfhe-rs folder, and the RUN commands as documentation.
Fixes #235