Closed
Conversation
85f1f80 to
d84db07
Compare
179177a to
7c3970f
Compare
Contributor
Author
|
Updated the PR with:
Also rebased the code onto current CC @proppy |
855c65c to
bba8a27
Compare
bba8a27 to
998a462
Compare
998a462 to
2398487
Compare
2398487 to
883f383
Compare
This was referenced Jan 13, 2025
- XLSStruct for easier handling and serializing/deserializing XLS structs - XLSChannel that serves as a dummy receiving channel - XLSMonitor that monitors transactions on an XLS channel - XLSDriver that can send data on an XLS channel - LatencyScoreboard that can measure latency between corresponding transactions on input and output buses - File-backed AXI memory python model Internal-tag: [#64075] Signed-off-by: Krzysztof Obłonczek <[email protected]>
Signed-off-by: Pawel Czarnecki <[email protected]>
Co-authred-by: Pawel Czarnecki <[email protected]> Co-authred-by: Robert Winkler <[email protected]> Signed-off-by: Michal Czyz <[email protected]> Signed-off-by: Pawel Czarnecki <[email protected]> Signed-off-by: Robert Winkler <[email protected]>
Signed-off-by: Pawel Czarnecki <[email protected]>
Signed-off-by: Pawel Czarnecki <[email protected]>
Signed-off-by: Pawel Czarnecki <[email protected]>
Signed-off-by: Pawel Czarnecki <[email protected]>
Signed-off-by: Pawel Czarnecki <[email protected]>
Signed-off-by: Maciej Torhan <[email protected]>
Signed-off-by: Pawel Czarnecki <[email protected]>
Signed-off-by: Pawel Czarnecki <[email protected]>
Signed-off-by: Pawel Czarnecki <[email protected]>
Signed-off-by: Maciej Torhan <[email protected]>
Remove references to buffer structs as those are not used anywhere Signed-off-by: Pawel Czarnecki <[email protected]>
Signed-off-by: Pawel Czarnecki <[email protected]>
Signed-off-by: Pawel Czarnecki <[email protected]>
Co-authored-by: Pawel Czarnecki <[email protected]> Signed-off-by: Maciej Torhan <[email protected]> Signed-off-by: Pawel Czarnecki <[email protected]>
Co-authored-by: Pawel Czarnecki <[email protected]> Co-authored-by: Robert Winkler <[email protected]> Signed-off-by: Maciej Torhan <[email protected]> Signed-off-by: Pawel Czarnecki <[email protected]> Signed-off-by: Robert Winkler <[email protected]>
Co-authored-by: Pawel Czarnecki <[email protected]> Signed-off-by: Robert Winkler <[email protected]> Signed-off-by: Pawel Czarnecki <[email protected]>
This reverts commit 04ad379225b706ddf492d440c673e77348d7a409.
Signed-off-by: Pawel Czarnecki <[email protected]>
Signed-off-by: Pawel Czarnecki <[email protected]>
Internal-tag: [#67096] Signed-off-by: Pawel Czarnecki <[email protected]>
Signed-off-by: Maciej Torhan <[email protected]> Signed-off-by: Krzysztof Obłonczek <[email protected]>
Signed-off-by: Krzysztof Obłonczek <[email protected]>
Internal-tag: [#66955] Signed-off-by: Pawel Czarnecki <[email protected]>
Signed-off-by: Pawel Czarnecki <[email protected]>
* Fix byte ordering when receiving a series of non-empty packets * Adjust MemReader DSLX tests Internal-tag: [#67272] Signed-off-by: Pawel Czarnecki <[email protected]>
…es function into a separate proc * Extract the operation of removing not-strobed bytes from input frames to a separate proc * Extract control logic to AxiStreamRemoveEmptyInternal proc * Optimize strobe calculation Internal-tag: [#67272] Signed-off-by: Pawel Czarnecki <[email protected]>
Fix paramaterization of the proc Internal-tag: [#67272] Signed-off-by: Pawel Czarnecki <[email protected]>
…ackets Add AxiStreamRemoveEmpty proc to the processing pipeline. It removes non-strobed bytes from the input AXI Stream frames and forms full frames (ensures that only the last input data packet won't be full). Internal-tag: [#67272] Signed-off-by: Pawel Czarnecki <[email protected]>
* Extract control logic to MemWriterInternal proc * Create alias for the MemWriter response type Internal-tag: [#67272] Signed-off-by: Pawel Czarnecki <[email protected]>
SequenceExecutor:
* Add output channel in the format compliant with MemWriter input data channel type
ZstdDecoder:
* Add MemWriter proc:
* Write request formed based on the address of the OutputBuffer CSR and
FrameContentSize field from the Frame Header
* Data to write is sent out to the proc by the SequenceExecutor
* Transition to the FINISH state (and triggers notify channel) only after
receiving the response from the MemWriter
* DSLX tests:
* Receive decoded data sent out on the AXI interface by the MemWriter proc
* Mock the output memory buffer as a DSLX array
* Cocotb tests:
* Move third-party verilog modules (AXI Interconnect) to external directory
* Replace AXI Interconnect with AXI Crossbar that handles simultaneous AXI Read
and Write transactions
* Add reference memory and fill it with expected data for comparison
against testbench memory at the end of the decoding
Internal-tag: [#67272]
Signed-off-by: Pawel Czarnecki <[email protected]>
* Remove Repacketizer proc * Remove stream-based output channels from * SequenceExecutor * ZstdDecoder Internal-tag: [#67272] Signed-off-by: Pawel Czarnecki <[email protected]>
* Decode multiple ZSTD frames in a single cocotb testbench * Add one cocotb testbench per type of the ZSTD frames: * Frames with RAW blocks only * Frames with RLE blocks only * Frames with Compressed blocks only (disabled) * Frames with mixed blocks (disabled) Internal-tag: [#67272] Signed-off-by: Pawel Czarnecki <[email protected]>
Internal-tag: [#67272] Signed-off-by: Pawel Czarnecki <[email protected]>
…on for verilog library Signed-off-by: Pawel Czarnecki <[email protected]>
…st cases Caused by timeouts after rebase - looks like regression in the performance of codegen Signed-off-by: Pawel Czarnecki <[email protected]>
…atus enums Signed-off-by: Pawel Czarnecki <[email protected]>
883f383 to
ae822bc
Compare
Member
|
Given this is still marked as draft, can we consolidate with #1857 as one PR? |
Member
|
Can we close this if favor for #1857? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR reworks the existing ZSTD Decoder to memory-based approach instead of relying on stream-based architecture.
The PR relies on peripherals (
MemReaderandMemWriter) for accessing external memory through AXI interface that are introduced in: #1613. It is also based on #1616.The Decoder is able to decompress ZSTD frames that consist of RAW and RLE blocks. This is tested in a verilog simulation with a cocotb testbench.
The changes in this PR include:
ZstdDecoderproc to work with memory-based approachZstdDecoderdecodecorpusFrameHeaderDecoder,BlockHeaderDecoder,Raw-andRleBlockDecodersto use memory-based approach instead of streaming input data from the input of the decoderCsrConfigandAxiCsrAccessorprocs that implement the internal registers of theZstdDecoderand provide external (AXI) and internal (native) facing interfaces for accessing thoseRleBlockDecoderprocBlockHeaderlibraryBlockDecoderprocDecDemuxproccommon_codegen_argslist to the BUILD fileThis PR is currently a
WIP. It is opened to showcase the work done and to create a space for discussion on certain topics. The following list enumerates task that are currently being addressed and which are required for this PR to be completed before it is marked asready for review.Next steps:
StatusCSRZstdDecoderproc (TypeCheck failure for a parameterized proc #1655)CC @proppy