feat: [#491] Fix the errors thrown by Lint/nilaway CI #642

kkumar-gcc · 2024-09-12T05:10:22Z

📑 Description

Closes goravel/goravel#491

@coderabbitai summary

✅ Checks

Added test cases for my code

coderabbitai · 2024-09-12T05:10:28Z

Important

Review skipped

Auto reviews are limited to specific labels.

🏷️ Labels to auto review (1)

🚀 Review Ready

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

codecov · 2024-09-12T05:17:47Z

Codecov Report

Attention: Patch coverage is 13.91753% with 167 lines in your changes missing coverage. Please review.

Project coverage is 70.36%. Comparing base (52b284c) to head (346ae15).
Report is 1 commits behind head on master.

Files with missing lines	Patch %	Lines
foundation/application.go	10.25%	35 Missing ⚠️
mail/job.go	0.00%	27 Missing ⚠️
database/service_provider.go	0.00%	17 Missing ⚠️
filesystem/file.go	0.00%	12 Missing and 2 partials ⚠️
mail/service_provider.go	0.00%	14 Missing ⚠️
console/service_provider.go	0.00%	12 Missing ⚠️
crypt/service_provider.go	0.00%	7 Missing ⚠️
console/progress_bar.go	0.00%	5 Missing ⚠️
crypt/aes.go	37.50%	4 Missing and 1 partial ⚠️
console/application.go	0.00%	3 Missing and 1 partial ⚠️
... and 12 more

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #642      +/-   ##
==========================================
- Coverage   71.00%   70.36%   -0.64%     
==========================================
  Files         189      189              
  Lines       11804    11926     +122     
==========================================
+ Hits         8381     8392      +11     
- Misses       2854     2956     +102     
- Partials      569      578       +9

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

devhaozi · 2024-09-12T06:34:26Z

CI failed, pls check.

github-actions

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.50.

Benchmark suite	Current: `58b5a40`	Previous: `cb355db`	Ratio
`Benchmark_Fatal`	`2e-7` ns/op 0 B/op 0 allocs/op	`1e-7` ns/op 0 B/op 0 allocs/op	`2`
`Benchmark_Fatal - ns/op`	`2e-7` ns/op	`1e-7` ns/op	`2`

This comment was automatically generated by workflow using github-action-benchmark.

kkumar-gcc · 2024-09-12T06:54:26Z

CI failed, pls check.

Sorry @devhaozi , it’s still not finished, so I’ll make it a draft for now. My local machine was hanging when I used NilAway, so I was pushing changes after making some adjustments to run NilAway properly.

hwbrzzl · 2024-09-18T02:16:33Z

CI failed

hwbrzzl · 2024-09-18T14:37:51Z

This PR is ready for review, right? it's still draft.

kkumar-gcc · 2024-09-18T14:41:07Z

It's completed from my side

hwbrzzl

Great PR, we can make a deeper optimization.

console/application.go

console/application_test.go

crypt/aes.go

hwbrzzl · 2024-09-18T14:49:42Z

crypt/service_provider.go

@@ -11,7 +11,7 @@ type ServiceProvider struct {

 func (crypt *ServiceProvider) Register(app foundation.Application) {
 	app.Singleton(Binding, func(app foundation.Application) (any, error) {
-		return NewAES(app.MakeConfig(), app.GetJson()), nil
+		return NewAES(app.MakeConfig(), app.GetJson())


Should judge nil here.

I don't think we should do that here it is better to return error here it will be judged when calling MakeAES anyways.

foundation/application.go

http/service_provider.go

mail/job.go

testing/test_case.go

hwbrzzl

Great PR 👍

console/service_provider.go

validation/service_provider.go

hwbrzzl

Great

solve potential nil error for console

c78885a

kkumar-gcc requested a review from a team as a code owner September 12, 2024 05:10

solve potential nil error for progress bar

610ac59

github-actions bot reviewed Sep 12, 2024

View reviewed changes

kkumar-gcc marked this pull request as draft September 12, 2024 06:55

kkumar-gcc and others added 21 commits September 12, 2024 13:10

solve potential nil error for str.When

51de4fe

resolve nil error for filesystem

b4ff711

resolve nil errors

45b921e

resolve nil errors

07dd54a

resolve nil errors

58d507a

fix:lint error

188012d

fix:test error

7f0dbc9

fix nil error

e0d739c

fix nil error

6495460

Merge branch 'master' into kkumar-gcc/#491

8f402dd

Merge branch 'master' into kkumar-gcc/#491

d04bada

Merge branch 'master' into kkumar-gcc/#491

4148d38

Merge branch 'master' into kkumar-gcc/#491

a94e968

fix nilaway erro

e359bb7

fix nil errors

1599d09

Merge branch 'master' into kkumar-gcc/#491

c9670a9

fix nil errors

70f858b

optimize file facade setting

9393c30

.

f131c24

.

066ae54

.

209f95d

nilaway:fix for json

fa97fd2

kkumar-gcc added 2 commits September 18, 2024 09:31

fix:lint

4a2f4aa

fix:test

f505eed

kkumar-gcc marked this pull request as ready for review September 18, 2024 14:47

hwbrzzl reviewed Sep 19, 2024

View reviewed changes

kkumar-gcc added 2 commits September 24, 2024 16:56

Merge branch 'master' into kkumar-gcc/#491

0f06b18

Merge branch 'master' into kkumar-gcc/#491

8e75482

coderabbitai bot previously approved these changes Sep 26, 2024

View reviewed changes

resolve comments

c01fbc9

kkumar-gcc dismissed coderabbitai[bot]’s stale review via c01fbc9 September 27, 2024 00:05

kkumar-gcc added 2 commits September 27, 2024 05:51

fix:test

70f0754

fix:nilaway

58b5a40

hwbrzzl reviewed Sep 29, 2024

View reviewed changes

console/service_provider.go Show resolved Hide resolved

validation/service_provider.go Outdated Show resolved Hide resolved

update recommendation

1697335

coderabbitai bot previously approved these changes Sep 29, 2024

View reviewed changes

update aes registration

bdcffb4

kkumar-gcc dismissed coderabbitai[bot]’s stale review via bdcffb4 September 29, 2024 14:44

coderabbitai bot previously approved these changes Sep 29, 2024

View reviewed changes

.

bb2b1af

kkumar-gcc dismissed coderabbitai[bot]’s stale review via bb2b1af September 29, 2024 14:55

Merge branch 'master' into kkumar-gcc/#491

403dc12

hwbrzzl previously approved these changes Sep 29, 2024

View reviewed changes

Merge branch 'master' into kkumar-gcc/#491

346ae15

kkumar-gcc dismissed hwbrzzl’s stale review via 346ae15 September 29, 2024 15:04

hwbrzzl approved these changes Sep 30, 2024

View reviewed changes

kkumar-gcc merged commit b310a98 into master Sep 30, 2024
10 of 13 checks passed

kkumar-gcc deleted the kkumar-gcc/#491 branch September 30, 2024 06:29

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: [#491] Fix the errors thrown by Lint/nilaway CI #642

feat: [#491] Fix the errors thrown by Lint/nilaway CI #642

kkumar-gcc commented Sep 12, 2024

coderabbitai bot commented Sep 12, 2024 •

edited

Loading

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

codecov bot commented Sep 12, 2024 •

edited

Loading

devhaozi commented Sep 12, 2024

github-actions bot left a comment •

edited

Loading

kkumar-gcc commented Sep 12, 2024

hwbrzzl commented Sep 18, 2024

hwbrzzl commented Sep 18, 2024

kkumar-gcc commented Sep 18, 2024

hwbrzzl left a comment

hwbrzzl Sep 18, 2024

kkumar-gcc Sep 26, 2024

hwbrzzl left a comment

hwbrzzl left a comment

feat: [#491] Fix the errors thrown by Lint/nilaway CI #642

feat: [#491] Fix the errors thrown by Lint/nilaway CI #642

Conversation

kkumar-gcc commented Sep 12, 2024

📑 Description

✅ Checks

coderabbitai bot commented Sep 12, 2024 • edited Loading

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

codecov bot commented Sep 12, 2024 • edited Loading

Codecov Report

devhaozi commented Sep 12, 2024

github-actions bot left a comment • edited Loading

Choose a reason for hiding this comment

⚠️ Performance Alert ⚠️

kkumar-gcc commented Sep 12, 2024

hwbrzzl commented Sep 18, 2024

hwbrzzl commented Sep 18, 2024

kkumar-gcc commented Sep 18, 2024

hwbrzzl left a comment

Choose a reason for hiding this comment

hwbrzzl Sep 18, 2024

Choose a reason for hiding this comment

kkumar-gcc Sep 26, 2024

Choose a reason for hiding this comment

hwbrzzl left a comment

Choose a reason for hiding this comment

hwbrzzl left a comment

Choose a reason for hiding this comment

coderabbitai bot commented Sep 12, 2024 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

codecov bot commented Sep 12, 2024 •

edited

Loading

github-actions bot left a comment •

edited

Loading