-
Notifications
You must be signed in to change notification settings - Fork 93
feat: [#491] Fix the errors thrown by Lint/nilaway CI #642
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 31 commits
Commits
Show all changes
41 commits
Select commit
Hold shift + click to select a range
c78885a
solve potential nil error for console
kkumar-gcc 610ac59
solve potential nil error for progress bar
kkumar-gcc 51de4fe
solve potential nil error for str.When
kkumar-gcc b4ff711
resolve nil error for filesystem
kkumar-gcc 45b921e
resolve nil errors
kkumar-gcc 07dd54a
resolve nil errors
kkumar-gcc 58d507a
resolve nil errors
kkumar-gcc 188012d
fix:lint error
kkumar-gcc 7f0dbc9
fix:test error
kkumar-gcc e0d739c
fix nil error
kkumar-gcc 6495460
fix nil error
kkumar-gcc 8f402dd
Merge branch 'master' into kkumar-gcc/#491
kkumar-gcc d04bada
Merge branch 'master' into kkumar-gcc/#491
kkumar-gcc 4148d38
Merge branch 'master' into kkumar-gcc/#491
kkumar-gcc a94e968
Merge branch 'master' into kkumar-gcc/#491
kkumar-gcc e359bb7
fix nilaway erro
kkumar-gcc 1599d09
fix nil errors
kkumar-gcc c9670a9
Merge branch 'master' into kkumar-gcc/#491
kkumar-gcc 70f858b
fix nil errors
kkumar-gcc 9393c30
optimize file facade setting
kkumar-gcc f131c24
.
kkumar-gcc 066ae54
.
kkumar-gcc 209f95d
.
kkumar-gcc 00616ce
remove nil error from facades
kkumar-gcc e9cbd2e
update crypt facade
kkumar-gcc c670ff7
nilaway:fix for session
kkumar-gcc 0ed6949
nilaway:fix for file
kkumar-gcc 5b43804
nilaway:fix for file
kkumar-gcc fa97fd2
nilaway:fix for json
kkumar-gcc 4a2f4aa
fix:lint
kkumar-gcc f505eed
fix:test
kkumar-gcc 0f06b18
Merge branch 'master' into kkumar-gcc/#491
kkumar-gcc 8e75482
Merge branch 'master' into kkumar-gcc/#491
kkumar-gcc c01fbc9
resolve comments
kkumar-gcc 70f0754
fix:test
kkumar-gcc 58b5a40
fix:nilaway
kkumar-gcc 1697335
update recommendation
kkumar-gcc bdcffb4
update aes registration
kkumar-gcc bb2b1af
.
kkumar-gcc 403dc12
Merge branch 'master' into kkumar-gcc/#491
kkumar-gcc 346ae15
Merge branch 'master' into kkumar-gcc/#491
kkumar-gcc File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
package crypt | ||
|
||
import ( | ||
"errors" | ||
) | ||
|
||
var ( | ||
ErrConfigNotSet = errors.New("config must not be nil") | ||
ErrJsonParserNotSet = errors.New("JSON parser must not be nil") | ||
ErrAppKeyNotSetInArtisan = errors.New("APP_KEY is required in artisan environment") | ||
ErrInvalidAppKeyLength = errors.New("invalid APP_KEY length") | ||
) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -11,7 +11,7 @@ | |
|
||
func (crypt *ServiceProvider) Register(app foundation.Application) { | ||
app.Singleton(Binding, func(app foundation.Application) (any, error) { | ||
return NewAES(app.MakeConfig(), app.GetJson()), nil | ||
return NewAES(app.MakeConfig(), app.GetJson()) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Should judge nil here. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I don't think we should do that here it is better to return error here it will be judged when calling |
||
}) | ||
} | ||
|
||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
package facades | ||
|
||
import "errors" | ||
|
||
var ( | ||
ErrApplicationNotSet = errors.New("application instance not initialized") | ||
) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
package filesystem | ||
|
||
import "errors" | ||
|
||
var ( | ||
ErrStorageFacadeNotSet = errors.New("storage facade not set") | ||
) |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.