-
-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Modrinth mod/modpack support #1391
base: master
Are you sure you want to change the base?
Conversation
Squashed from Pyroglyph/GDLauncher/tree/modrinth-support
Modrinth said on Twitter that api user should have a User-Agent. |
I found some issues with the build #1746 can you tell me if you fixed them or not?
|
@AshtakaOOf |
I would definetly recommend getting it working as soon as possible as more and more mods are moving to Modrinth |
Would recommend just adding a pull request after this to add QuiltMC support to the patch because there's been no activity on that pull request and alot of big mods are moving and it's starting to really get annoying |
Me and Pyro had already talked about this before I started the PR :P |
I've come back after a few weeks off this project and suddenly it wasn't working. I did some investigation and found that when I merged this commit caused a total freeze (but not a crash) when opening the Manage window of an instance. It happens on both Windows and Linux on 2 different machines, so it's not isolated. I haven't figured out why yet. I've rewritten the history of my branch to remove the times I merged from the master branch and that has stopped the issue, hence the recent force push. Edit: The commit I mentioned earlier is the problem. Merging the latest master in breaks it, reverting that commit fixes it. |
Hello! I was wondering if you had any leads as to what the issue is? I wanted to take a crack at it and I'm curious if there was any work already put into resolving it. |
Hi! Any progress on this? |
Status...? Iris has just been removed from CurseForge... now would be THE time to get on with this. |
Please stop waiting on the Quilt pull. Nothing is happening with it |
Are we still waiting for the Qulit support? |
Quilt has been added already to the rewrite. We will release it in open beta by end of August. |
(This picks up where #1352 left off after the big history clean)
Purpose
Currently, GDLauncher does not support downloading mods/modpacks hosted on the Modrinth platform. This feature has been requested in issue #768.
I'm aware of GDevs' other project ferium which already supports Modrinth, and also the
gdlib-refactor
branch (which I assume may eventually succeed GDLauncher?), but that branch is far from completion.Approach
This PR allows users to search for and install mods and modpacks hosted on Modrinth in the same way that they can currently be installed from CurseForge and FTB.
The implementation is highly based on the existing CurseForge/FTB installer code so it adds no new dependencies, which I see as an advantage.
Open Questions and Pre-Merge TODOs
Learning
I have read the Modrinth API docs (linked below).
Resources