Group annotations by dependency and print a warning if the dependency is missing #752
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
dnestoro
force-pushed
the
dnestoro/register-only-available-junit-annotations
branch
from
55c8c3e to
97cced1
Compare
melix
reviewed
Jul 24, 2025
| AnnotationUtils.registerClassesFromAnnotationForReflection(testClass, registry, FieldSource.class, JupiterConfigProvider::handleFieldSource); | ||
| } catch (NoClassDefFoundError e) { | ||
| System.out.println("[junit-platform-native] Cannot register @FieldSource annotation from org.junit.jupiter.params." + | ||
| " Please verify that you have this dependency (with version greater than JUnit 5.13) if you want to use this annotation."); |
There was a problem hiding this comment.
mmm, I'm not sure we want to print that out. It will be annoying for users who do NOT want this.
There was a problem hiding this comment.
So we should use debug()? Could we see the failure at runtime because we didn't register those annotations for reflection (and users won't see why we didn't register them)?
This was referenced Jul 26, 2025
dnestoro
force-pushed
the
dnestoro/register-only-available-junit-annotations
branch
from
05c0723 to
db6c391
Compare
melix
approved these changes
Aug 19, 2025
dnestoro
deleted the
dnestoro/register-only-available-junit-annotations
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we are not duplicating JUnit dependencies, we could end up in a situation where:
org.junit.jupiter:junit-jupiter-params)NoClassDefFoundErrorSolution: group annotations by the dependency that introduces them, and print a warning if the dependency is not available.
Fixes: #747