cache: Change default of -dns-ignore-startup-failures to true #705
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Arve Knudsen <[email protected]>
aknuds1
force-pushed
the
arve/dns-ignore-startup-failures
branch
from
80f6d62 to
eef1103
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR changes the default value of the -dns-ignore-startup-failures flag to true in the Memcached client configuration. It also updates the corresponding changelog entry to document the new default.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| cache/memcached_client.go | Updated the default DNSIgnoreStartupFailures flag to true |
| CHANGELOG.md | Modified the changelog entry to reflect the new flag default |
Comments suppressed due to low confidence (1)
cache/memcached_client.go:144
- Consider adding or updating tests to verify that the Memcached client correctly handles DNS resolution failures with the new default flag.
f.BoolVar(&c.DNSIgnoreStartupFailures, prefix+"dns-ignore-startup-failures", true, "Allow client creation even if initial DNS resolution fails.")
4 tasks
charleskorn
approved these changes
Jun 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Change the default of the
-dns-ignore-startup-failuresflag to true. It's an experimental flag added by @tinitiuset for use within Grafana Mimir, and the Mimir team is agreeing that true should be the new default.NB: I'm adding the PR to the existing CHANGELOG entry for the flag, since the previous change to the flag did the same.
Which issue(s) this PR fixes:
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]