-
Notifications
You must be signed in to change notification settings - Fork 595
operations/mimir: Upstream Jsonnet changes from r334 #11602
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
15b5caa
to
f3bff18
Compare
5a3180f
to
fdfefa1
Compare
Signed-off-by: Arve Knudsen <[email protected]>
…the ruler Signed-off-by: Arve Knudsen <[email protected]>
Signed-off-by: Arve Knudsen <[email protected]>
fdfefa1
to
3a35b7c
Compare
Co-authored-by: Taylor C <[email protected]>
Co-authored-by: Taylor C <[email protected]>
💻 Deploy preview deleted. |
Signed-off-by: Arve Knudsen <[email protected]>
b8fb399
to
da6795c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR applies upstream Jsonnet changes from r334 to the operations/mimir component, addressing Memcached dependency on startup and configuring the Kafka client for the ruler. Key changes include:
- Conditionally adding a Kafka producer buffered-bytes setting in the ruler configuration based on ingest storage.
- Consistently updating test files to include the new Kafka configuration parameter.
- Updating default values in documentation, help text, and config descriptors for Memcached DNS resolution.
Reviewed Changes
Copilot reviewed 18 out of 18 changed files in this pull request and generated 1 comment.
Show a summary per file
File | Description |
---|---|
operations/mimir/ruler.libsonnet | Adds a conditional block to set Kafka producer-max-buffered-bytes when ingest storage is enabled. |
operations/mimir-tests/*.yaml (multiple files) | Each test file now includes the new Kafka producer-max-buffered-bytes configuration parameter. |
go.mod | Updates the dependency for github.com/grafana/dskit to a newer commit. |
docs/sources/mimir/configure/configuration-parameters/index.md | Updates the default value for dns-ignore-startup-failures to true. |
cmd/mimir/help-all.txt.tmpl | Updates help text to reflect the new default value for dns-ignore-startup-failures. |
cmd/mimir/config-descriptor.json | Updates configuration descriptors to reflect the new default value for dns-ignore-startup-failures. |
CHANGELOG.md | Adds entries to document the changes made in this PR. |
Comments suppressed due to low confidence (1)
operations/mimir/ruler.libsonnet:34
- There is a typo in the comment ('ot he ingester' should be 'to the ingester').
// Increased from 2s to 10s in order to accommodate writing large rule results ot he ingester.
Signed-off-by: Arve Knudsen <[email protected]>
What this PR does
Upstream operations/mimir Jsonnet changes from r334:
The first is upstreamed through upgrading to latest dskit, in which the corresponding flag
-dns-ignore-startup-failures
's default changes to true. Therefore, we don't need to set the flag via Jsonnet any longer.I've tested applying the PR's changes, and can see there are no differences versus our r334 cloud deployment (given that Jsonnet corresponding to change 1 is kept until the right Mimir release).
Which issue(s) this PR fixes or relates to
Fixes #
Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]
.about-versioning.md
updated with experimental features.